Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: ipc/ipc_message_utils.cc

Issue 6368094: -Wuninitialized fixes Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/webdriver/commands/find_element_commands.cc ('k') | webkit.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message_utils.cc
diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc
index 5216a8602eb680119fdade818f92217fd7e0ba3c..7c3ef66b05228cee10af5272334876d8b23eba85 100644
--- a/ipc/ipc_message_utils.cc
+++ b/ipc/ipc_message_utils.cc
@@ -455,7 +455,7 @@ void ParamTraits<LogData>::Write(Message* m, const param_type& p) {
}
bool ParamTraits<LogData>::Read(const Message* m, void** iter, param_type* r) {
- int type;
+ int type = 0; // clang pr9122
bool result =
ReadParam(m, iter, &r->channel) &&
ReadParam(m, iter, &r->routing_id) &&
@@ -465,7 +465,8 @@ bool ParamTraits<LogData>::Read(const Message* m, void** iter, param_type* r) {
ReadParam(m, iter, &r->receive) &&
ReadParam(m, iter, &r->dispatch) &&
ReadParam(m, iter, &r->params);
- r->type = static_cast<uint16>(type);
+ if (result) // real (but uninteresting) fix
+ r->type = static_cast<uint16>(type);
return result;
}
« no previous file with comments | « chrome/test/webdriver/commands/find_element_commands.cc ('k') | webkit.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698