-Wuninitialized fixes

chrome/browser/dom_ui/options/browser_options_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/dom_ui/options/browser_options_handler.h"
 
 #include "base/basictypes.h"
 #include "base/scoped_ptr.h"
 #include "base/singleton.h"
 #include "base/string_number_conversions.h"
@@ skipping 137 matching lines @@
 
 void BrowserOptionsHandler::SetHomePage(const ListValue* args) {
   std::string url_string;
   std::string do_fixup_string;
   int do_fixup;
   if (args->GetSize() != 2 ||
       !args->GetString(0, &url_string) ||
       !args->GetString(1, &do_fixup_string) ||
       !base::StringToInt(do_fixup_string, &do_fixup)) {
     CHECK(false);
+    return;  // needs analysis why this is needed
   };
 
   if (do_fixup) {
     GURL fixed_url = URLFixerUpper::FixupURL(url_string, std::string());
     url_string = fixed_url.spec();
   }
   homepage_.SetValueIfNotManaged(url_string);
 }
 
 void BrowserOptionsHandler::UpdateDefaultBrowserState() {
@@ skipping 208 matching lines @@
 
 void BrowserOptionsHandler::AddStartupPage(const ListValue* args) {
   std::string url_string;
   std::string index_string;
   int index;
   if (args->GetSize() != 2 ||
       !args->GetString(0, &url_string) ||
       !args->GetString(1, &index_string) ||
       !base::StringToInt(index_string, &index)) {
     CHECK(false);
+    return;  // needs analysis why this is needed
   };
 
   if (index == -1)
     index = startup_custom_pages_table_model_->RowCount();
   else
     ++index;
 
   GURL url = URLFixerUpper::FixupURL(url_string, std::string());
 
   startup_custom_pages_table_model_->Add(index, url);
   SaveStartupPagesPref();
 }
 
 void BrowserOptionsHandler::EditStartupPage(const ListValue* args) {
   std::string url_string;
   std::string index_string;
   int index;
   if (args->GetSize() != 2 ||
       !args->GetString(0, &index_string) ||
       !base::StringToInt(index_string, &index) ||
       !args->GetString(1, &url_string)) {
     CHECK(false);
+    return;  // needs analysis why this is needed
   };
 
   if (index < 0 || index > startup_custom_pages_table_model_->RowCount()) {
     NOTREACHED();
     return;
   }
 
   std::vector<GURL> urls = startup_custom_pages_table_model_->GetURLs();
   urls[index] = URLFixerUpper::FixupURL(url_string, std::string());
   startup_custom_pages_table_model_->SetURLs(urls);
 }
 
 void BrowserOptionsHandler::SaveStartupPagesPref() {
   PrefService* prefs = dom_ui_->GetProfile()->GetPrefs();
 
   SessionStartupPref pref = SessionStartupPref::GetStartupPref(prefs);
   pref.urls = startup_custom_pages_table_model_->GetURLs();
 
   SessionStartupPref::SetStartupPref(prefs, pref);
 }