Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 6368074: Fix bug in pretenuring function literals from optimized code. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3388 matching lines...) Expand 10 before | Expand all | Expand 10 after
3399 __ mov(edx, FieldOperand(ebx, size - kPointerSize)); 3399 __ mov(edx, FieldOperand(ebx, size - kPointerSize));
3400 __ mov(FieldOperand(eax, size - kPointerSize), edx); 3400 __ mov(FieldOperand(eax, size - kPointerSize), edx);
3401 } 3401 }
3402 } 3402 }
3403 3403
3404 3404
3405 void LCodeGen::DoFunctionLiteral(LFunctionLiteral* instr) { 3405 void LCodeGen::DoFunctionLiteral(LFunctionLiteral* instr) {
3406 // Use the fast case closure allocation code that allocates in new 3406 // Use the fast case closure allocation code that allocates in new
3407 // space for nested functions that don't need literals cloning. 3407 // space for nested functions that don't need literals cloning.
3408 Handle<SharedFunctionInfo> shared_info = instr->shared_info(); 3408 Handle<SharedFunctionInfo> shared_info = instr->shared_info();
3409 bool pretenure = !instr->hydrogen()->pretenure(); 3409 bool pretenure = instr->hydrogen()->pretenure();
3410 if (shared_info->num_literals() == 0 && !pretenure) { 3410 if (shared_info->num_literals() == 0 && !pretenure) {
3411 FastNewClosureStub stub; 3411 FastNewClosureStub stub;
3412 __ push(Immediate(shared_info)); 3412 __ push(Immediate(shared_info));
3413 CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr); 3413 CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr);
3414 } else { 3414 } else {
3415 __ push(esi); 3415 __ push(esi);
3416 __ push(Immediate(shared_info)); 3416 __ push(Immediate(shared_info));
3417 __ push(Immediate(pretenure 3417 __ push(Immediate(pretenure
3418 ? Factory::true_value() 3418 ? Factory::true_value()
3419 : Factory::false_value())); 3419 : Factory::false_value()));
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
3608 ASSERT(osr_pc_offset_ == -1); 3608 ASSERT(osr_pc_offset_ == -1);
3609 osr_pc_offset_ = masm()->pc_offset(); 3609 osr_pc_offset_ = masm()->pc_offset();
3610 } 3610 }
3611 3611
3612 3612
3613 #undef __ 3613 #undef __
3614 3614
3615 } } // namespace v8::internal 3615 } } // namespace v8::internal
3616 3616
3617 #endif // V8_TARGET_ARCH_IA32 3617 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698