Adding crash reporting on Linux for the GPU process....

Adding crash reporting on Linux for the GPU process.
BUG=49577
TEST=Tested as follows:
1. Set GYP_DEFINES="linux_breakpad=1"
2. From src/ issue:
./build/gyp_chromium -f make
3. Build chromium
4. Run: chrome --enable-crash-reporter
5. Visit a page that causes the gpu process to be launched (e.g. "about:gpu")
6. Go to "about:gpucrash" to force a gpu process crash
7. Verify that a .dmp file is create in ~/.config/chromium/Crash\ Reports/
 

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73639

[Vangelis Kokkevis, 2011-02-03 07:47:00]

CL ready for review.  Would you mind taking a look or suggest an appropriate
reviewer?  Thanks!

[Lei Zhang, 2011-02-03 08:00:44]

Looks like you need to fix up crash_handler_host_linux_stub.cc for Chromium.

http://codereview.chromium.org/6368072/diff/1/chrome/browser/crash_handler_ho...
File chrome/browser/crash_handler_host_linux.cc (right):

http://codereview.chromium.org/6368072/diff/1/chrome/browser/crash_handler_ho...
chrome/browser/crash_handler_host_linux.cc:365: process_type_ = "gpu-process";
nit: gpu is fine.

[Vangelis Kokkevis, 2011-02-03 08:26:33]

Thank you for the quick response, Lei.  I modified
crash_handler_host_linux_stub.cc and submitted another try job.

http://codereview.chromium.org/6368072/diff/1/chrome/browser/crash_handler_ho...
File chrome/browser/crash_handler_host_linux.cc (right):

http://codereview.chromium.org/6368072/diff/1/chrome/browser/crash_handler_ho...
chrome/browser/crash_handler_host_linux.cc:365: process_type_ = "gpu-process";
On 2011/02/03 08:00:45, Lei Zhang wrote:
> nit: gpu is fine.

I wasn't sure if this is supposed to match the process type name that's set in:
https://cs.corp.google.com/#chrome/trunk/src/chrome/app/chrome_main.cc&q=kgpu...

and defined in:
https://cs.corp.google.com/#chrome/trunk/src/chrome/common/chrome_switches.cc...

On the crash dashboard for the other platforms, gpu process crashes get a
process type = "gpu-process" .

[Lei Zhang, 2011-02-03 08:40:59]

On 2011/02/03 08:26:33, Vangelis Kokkevis wrote:
> Thank you for the quick response, Lei.  I modified
> crash_handler_host_linux_stub.cc and submitted another try job.
> 
>
http://codereview.chromium.org/6368072/diff/1/chrome/browser/crash_handler_ho...
> File chrome/browser/crash_handler_host_linux.cc (right):
> 
>
http://codereview.chromium.org/6368072/diff/1/chrome/browser/crash_handler_ho...
> chrome/browser/crash_handler_host_linux.cc:365: process_type_ = "gpu-process";
> On 2011/02/03 08:00:45, Lei Zhang wrote:
> > nit: gpu is fine.
> 
> I wasn't sure if this is supposed to match the process type name that's set
in:
>
https://cs.corp.google.com/#chrome/trunk/src/chrome/app/chrome_main.cc&q=kgpu...
> 
> and defined in:
>
https://cs.corp.google.com/#chrome/trunk/src/chrome/common/chrome_switches.cc...
> 
> On the crash dashboard for the other platforms, gpu process crashes get a
> process type = "gpu-process" .

The other process types show up as "browser", "renderer", and "plugin", without
"-process" in their name. However, if the other platforms already have gpu
crashes labeled as "gpu-process", then it's fine to do the same on Linux to keep
it consistent.

LGTM (and I'll look forward to the GPU crash reports)