Issue 6368064: Allow signing scripts to (optionally) set the firmware and kernel versions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6368064: Allow signing scripts to (optionally) set the firmware and kernel versions (Closed)

Created:
9 years, 10 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler, Will Drewry

CC:
chromium-os-reviews_chromium.org, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

Allow signing scripts to (optionally) set the firmware and kernel versions Versions are (optionally) read from a file with the format firmware_version=<firmware version> kernel_version=<kernel version> The new scripts and arguments are compatible with older versions of the script. Change-Id: I502df69d6c02caee75cdf010e61812be408a64e0 BUG=chromium-os:8016 TEST=manually tested all invocations of sign_official_build {verify|usb|ssd|install|recovery} with and without versions. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8ae7b0e

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -82 lines)			Patch
M	scripts/image_signing/resign_firmwarefd.sh	View	1 2	3 chunks	+25 lines, -23 lines	0 comments	Download
M	scripts/image_signing/resign_image.sh	View		1 chunk	+29 lines, -33 lines	0 comments	Download
M	scripts/image_signing/resign_kernel_partition.sh	View		2 chunks	+20 lines, -12 lines	0 comments	Download
M	scripts/image_signing/sign_official_build.sh	View	1 2	16 chunks	+39 lines, -14 lines	0 comments	Download
A	scripts/image_signing/versions.default	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 6368064: Allow signing scripts to (optionally) set the firmware and kernel versions (Closed)

Description

Patch Set 1 #

Patch Set 2 : add an example template #

Patch Set 3 : ws fix for real #

Messages