Implements DoubleToI on ARM. Refactor some VFP code at the same time and...

Implements DoubleToI on ARM. Refactor some VFP code at the same time and
fix the simulator behaviour.

BUG=none
TEST=added to cctest/test-assembler-arm.cc

Committed: http://code.google.com/p/v8/source/detail?r=6629

[Søren Thygesen Gjesse, 2011-02-03 09:07:17]

LGTM with the comments addressed.

http://codereview.chromium.org/6368053/diff/1/src/arm/constants-arm.h
File src/arm/constants-arm.h (right):

http://codereview.chromium.org/6368053/diff/1/src/arm/constants-arm.h#newcode410
src/arm/constants-arm.h:410: }
Remove a few empty lines.

http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:2670: EmitVFPTruncate(kRoundToMinusInf,
To much indentation.

http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:3334: EmitVFPTruncate(rounding_mode,
Indentation.

http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:3353: 
Indentation.

http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcod...
src/arm/simulator-arm.cc:2564: FPSCR_rounding_mode_ =
4 char indent.

http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcod...
src/arm/simulator-arm.cc:2665: (val < -0.5) ||
Please comment on what val != val checks. Maybe have a separate check for this
before the switch. How about using isnan instead?

http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcod...
src/arm/simulator-arm.cc:2737: VFPRoundingMode mode = (instr->Bit(7) != 1) ?
FPSCR_rounding_mode_
Indentation.

http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcod...
src/arm/simulator-arm.cc:2747: int temp = unsigned_integer ?
static_cast<uint32_t>(val) :
Please be consistent with where the : is placed.

http://codereview.chromium.org/6368053/diff/1/src/checks.h
File src/checks.h (right):

http://codereview.chromium.org/6368053/diff/1/src/checks.h#newcode76
src/checks.h:76: "CHECK_EQ(%s, %s) failed\n"
I don't think we want tabs in the output.

[Rodolph Perfetta, 2011-02-03 15:03:39]

comments addressed.

http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:2670: EmitVFPTruncate(kRoundToMinusInf,
On 2011/02/03 09:07:17, Søren Gjesse wrote:
> To much indentation.

Done.

http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:3334: EmitVFPTruncate(rounding_mode,
On 2011/02/03 09:07:17, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/6368053/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:3353: 
On 2011/02/03 09:07:17, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcod...
src/arm/simulator-arm.cc:2564: FPSCR_rounding_mode_ =
On 2011/02/03 09:07:17, Søren Gjesse wrote:
> 4 char indent.

Done.

http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcod...
src/arm/simulator-arm.cc:2665: (val < -0.5) ||
made a separate check for NaN.

http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcod...
src/arm/simulator-arm.cc:2737: VFPRoundingMode mode = (instr->Bit(7) != 1) ?
FPSCR_rounding_mode_
On 2011/02/03 09:07:17, Søren Gjesse wrote:
> Indentation.

Done.

http://codereview.chromium.org/6368053/diff/1/src/arm/simulator-arm.cc#newcod...
src/arm/simulator-arm.cc:2747: int temp = unsigned_integer ?
static_cast<uint32_t>(val) :
On 2011/02/03 09:07:17, Søren Gjesse wrote:
> Please be consistent with where the : is placed.

Done.

http://codereview.chromium.org/6368053/diff/1/src/checks.h
File src/checks.h (right):

http://codereview.chromium.org/6368053/diff/1/src/checks.h#newcode76
src/checks.h:76: "CHECK_EQ(%s, %s) failed\n"
On 2011/02/03 09:07:17, Søren Gjesse wrote:
> I don't think we want tabs in the output.

Done.

[Søren Thygesen Gjesse, 2011-02-04 07:10:30]

LGTM

Committed: http://code.google.com/p/v8/source/detail?r=6629

Thank you for the patch.