Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 6368051: A MessageObject is a purely internal object to hold information about (Closed)

Created:
9 years, 10 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

A MessageObject is a purely internal object to hold information about an error message that needs to be generated and reported. This change hides all of the error information from JavaScript code so user callbacks cannot get hold of it. Committed: http://code.google.com/p/v8/source/detail?r=6574

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -124 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 7 chunks +20 lines, -16 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/factory.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/heap.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/heap.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M src/messages.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/messages.cc View 1 chunk +30 lines, -52 lines 0 comments Download
M src/messages.js View 7 chunks +23 lines, -33 lines 0 comments Download
M src/objects.h View 5 chunks +69 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/objects-inl.h View 10 chunks +40 lines, -15 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M src/objects-visiting.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
9 years, 10 months ago (2011-02-02 12:04:24 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/6368051/diff/1/src/heap.h File src/heap.h (right): http://codereview.chromium.org/6368051/diff/1/src/heap.h#newcode635 src/heap.h:635: // Please not that this does not perform ...
9 years, 10 months ago (2011-02-02 13:08:17 UTC) #2
Mads Ager (chromium)
9 years, 10 months ago (2011-02-02 13:30:36 UTC) #3
http://codereview.chromium.org/6368051/diff/1/src/heap.h
File src/heap.h (right):

http://codereview.chromium.org/6368051/diff/1/src/heap.h#newcode635
src/heap.h:635: // Please not that this does not perform a garbage collection.
On 2011/02/02 13:08:17, Søren Gjesse wrote:
> not -> note

Done.

http://codereview.chromium.org/6368051/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):

http://codereview.chromium.org/6368051/diff/1/test/cctest/test-api.cc#oldcode...
test/cctest/test-api.cc:2410: CompileRun("asdf;");
On 2011/02/02 13:08:17, Søren Gjesse wrote:
> Why did you remove this?

Good catch! Thanks, that was unintentional!

Powered by Google App Engine
This is Rietveld 408576698