src/ia32/codegen-ia32.cc - Issue 6368050: Fix Math.pow(-0, 0.5) and Math.pow(-0, -0.5). These are not equal to sqrt(-0...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/codegen-ia32.cc

Issue 6368050: Fix Math.pow(-0, 0.5) and Math.pow(-0, -0.5). These are not equal to sqrt(-0... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/codegen-ia32.cc

===================================================================

--- src/ia32/codegen-ia32.cc (revision 6572)

+++ src/ia32/codegen-ia32.cc (working copy)

@@ -7951,10 +7951,12 @@

__ j(not_equal, &not_minus_half);

// Calculates reciprocal of square root.

- // Note that 1/sqrt(x) = sqrt(1/x))

- __ divsd(xmm3, xmm0);

+ // sqrtsd returns -0 when input is -0. ECMA spec requires +0.

+ __ xorpd(xmm1, xmm1);

+ __ addsd(xmm1, xmm0);

+ __ sqrtsd(xmm1, xmm1);

+ __ divsd(xmm3, xmm1);

__ movsd(xmm1, xmm3);

- __ sqrtsd(xmm1, xmm1);

__ jmp(&allocate_return);

// Test for 0.5.

@@ -7966,7 +7968,9 @@

__ ucomisd(xmm2, xmm1);

call_runtime.Branch(not_equal);

// Calculates square root.

- __ movsd(xmm1, xmm0);

+ // sqrtsd returns -0 when input is -0. ECMA spec requires +0.

+ __ xorpd(xmm1, xmm1);

+ __ addsd(xmm1, xmm0);

__ sqrtsd(xmm1, xmm1);

JumpTarget done;

« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »