Issue 6368050: Fix Math.pow(-0, 0.5) and Math.pow(-0, -0.5). These are not equal to sqrt(-0...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6368050: Fix Math.pow(-0, 0.5) and Math.pow(-0, -0.5). These are not equal to sqrt(-0... (Closed)

Created:
9 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix Math.pow(-0, 0.5) and Math.pow(-0, -0.5). These are not equal to sqrt(-0) and 1/sqrt(-0). Add tests for these cases. Fixes V8 issue 1088. BUG=1088 TEST=test/mjsunit/math-pow.js Committed: http://code.google.com/p/v8/source/detail?r=6573

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -32 lines)			Patch
M	src/arm/codegen-arm.cc	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
M	src/assembler.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
M	test/mjsunit/math-pow.js	View	1	4 chunks	+29 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages