Issue 6368045: This fixes a build break in mod_image_for_test.sh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6368045: This fixes a build break in mod_image_for_test.sh (Closed)

Created:
9 years, 10 months ago by Greg Spencer (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

This fixes a build break in mod_image_for_test.sh BUG=chromium-os:4230 TEST=Ran mod_image_for_test.sh locally. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c244656

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	mod_image_for_test.sh	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

anush

9 years, 10 months ago (2011-02-02 06:43:40 UTC) #2

lgtm

On Tue, Feb 1, 2011 at 10:34 PM, <gspencer@chromium.org> wrote:

> Reviewers: anush,
>
> Description:
> This fixes a build break in mod_image_for_test.sh
>
> BUG=chromium-os:4230
> TEST=Ran mod_image_for_test.sh locally.
>
> Please review this at http://codereview.chromium.org/6368045/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M mod_image_for_test.sh
>
>
> Index: mod_image_for_test.sh
> diff --git a/mod_image_for_test.sh b/mod_image_for_test.sh
> index
>
f9fec77c33112b8bf72d163466144d137a40b0d6..d0bd096ee174291db0da2f3386dabeb564586889
> 100755
> --- a/mod_image_for_test.sh
> +++ b/mod_image_for_test.sh
> @@ -190,7 +190,6 @@ IMAGE_DIR=$(dirname "$FLAGS_image")
>  IMAGE_NAME="$(basename "$FLAGS_image")"
>  ROOT_FS_DIR="$IMAGE_DIR/rootfs"
>  STATEFUL_DIR="$IMAGE_DIR/stateful_partition"
> -SCRIPTS_DIR=${SCRIPT_ROOT}
>  DEV_USER="chronos"
>
>  trap cleanup EXIT
>
>
>

Expand Messages | Collapse Messages