cros_workon: apply gspencer's cleanup from issue 6240018

cros_workon: apply gspencer's cleanup from issue 6240018

Note: this is the moved version of cros_workon

BUG=11507
TEST=./cros_workon --board x86-generic list --all

Change-Id: I4bee245743b4390e1efb634887ea8858c4540f34

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f75ed18

[robotboy, 2011-02-01 21:46:13]

Looking for clarification, I may have missed something.

Thanks,
    Anton

http://codereview.chromium.org/6368032/diff/1/host/cros_workon
File host/cros_workon (right):

http://codereview.chromium.org/6368032/diff/1/host/cros_workon#newcode18
host/cros_workon:18: local common_paths=(/usr/lib/crosutils $(dirname
"$(readlink -f "$0")"))
Is this correct?  I don't think common.sh is ever right next to cros_workon?  In
what instance does the second path find common.sh?

[Mandeep Singh Baines, 2011-02-01 21:58:01]

Good point. Removed boilerplate.

On 2011/02/01 21:46:13, robotboy wrote:
> Looking for clarification, I may have missed something.
> 
> Thanks,
>     Anton
> 
> http://codereview.chromium.org/6368032/diff/1/host/cros_workon
> File host/cros_workon (right):
> 
> http://codereview.chromium.org/6368032/diff/1/host/cros_workon#newcode18
> host/cros_workon:18: local common_paths=(/usr/lib/crosutils $(dirname
> "$(readlink -f "$0")"))
> Is this correct?  I don't think common.sh is ever right next to cros_workon? 
In
> what instance does the second path find common.sh?

[robotboy, 2011-02-01 22:00:36]

LGTM, thanks.

[Greg Spencer (Chromium), 2011-02-01 23:19:49]

LGTM.  You just like seeing me merge things, right? :)

(I already applied these changes in my tree, and they'll go in as soon as I've
tested them on a clean tree).

[Greg Spencer (Chromium), 2011-02-01 23:22:08]

On 2011/02/01 23:19:49, Greg Spencer (Chromium) wrote:
> LGTM.  You just like seeing me merge things, right? :)
> 
> (I already applied these changes in my tree, and they'll go in as soon as I've
> tested them on a clean tree).

But do feel free checking this in, I'm just pulling your leg about the merging.