Ignore SIGTTOU.

Ignore SIGTTOU.  

SIGTTOU was causing a hang in terminals with tostop set (which seems to be the default for my local emacs configuration).

Signed-off-by: David Rochberg (rochberg@chromium.org)
BUG=chromiumos:7716
TEST=stty tostop, then run with and without this change.  Without the change, tests will hang in a SIGTTOU/syscall-restarted loop.

Change-Id: Ib5317e238b68089d71e8e57418717e7553fd64d9

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8a60d1e

[ericli, 2011-02-01 18:11:57]

Hi David,

I was lightly following a previous thread about the SIGTTOU signal handling.
Why it could not handled inside run_remote_tests.sh? I maybe missed some of
the email conversations. Adding this logic into autotest harness seems a
sub-optimal solution.

Eric

On Tue, Feb 1, 2011 at 8:30 AM, <rochberg@chromium.org> wrote:

> Reviewers: petkov,
>
> Description:
> Ignore SIGTTOU.
>
> SIGTTOU was causing a hang in terminals with tostop set (which seems to be
> the
> default for my local emacs configuration).
>
> Signed-off-by: David Rochberg (rochberg@chromium.org)
> BUG=chromiumos:7716
> TEST=stty tostop, then run with and without this change.  Without the
> change,
> tests will hang in a SIGTTOU/syscall-restarted loop.
>
> Change-Id: Ib5317e238b68089d71e8e57418717e7553fd64d9
>
> Please review this at http://codereview.chromium.org/6368022/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/autotest.git@master
>
> Affected files:
>  M server/autoserv
>
>
> Index: server/autoserv
> diff --git a/server/autoserv b/server/autoserv
> index
>
b3e900b3396724771a357c76f6c6f27a0668f932..8b3d8703b96fdf442541b4e4f07fd563caef74cd
> 100755
> --- a/server/autoserv
> +++ b/server/autoserv
> @@ -53,6 +53,9 @@ def run_autoserv(pid_file_manager, results, parser):
>     # Set signal handler
>     signal.signal(signal.SIGTERM, handle_sigterm)
>
> +    # Ignore SIGTTOU in case we are run in a terminal that sets tostop
> +    signal.signal(signal.SIGTTOU, signal.SIG_IGN)
> +
>     # Server side tests that call shell scripts often depend on $USER being
> set
>     # but depending on how you launch your autotest scheduler it may not be
> set.
>     os.environ['USER'] = getpass.getuser()
>
>
>


-- 
Eric Li
李咏竹
Google Kirkland

[rochberg, 2011-02-01 18:19:31]

The problem is not specific to run_remote_tests.sh, it's specific to
autotest.  So fixing it here (and upstreaming) should fix it for everybody,
not just run_remote_tests.sh.

-david


On Tue, Feb 1, 2011 at 1:11 PM, Eric Li(李咏竹) <ericli@chromium.org> wrote:

> Hi David,
>
> I was lightly following a previous thread about the SIGTTOU signal
> handling. Why it could not handled inside run_remote_tests.sh? I maybe
> missed some of the email conversations. Adding this logic into autotest
> harness seems a sub-optimal solution.
>
> Eric
>
>
> On Tue, Feb 1, 2011 at 8:30 AM, <rochberg@chromium.org> wrote:
>
>> Reviewers: petkov,
>>
>> Description:
>> Ignore SIGTTOU.
>>
>> SIGTTOU was causing a hang in terminals with tostop set (which seems to be
>> the
>> default for my local emacs configuration).
>>
>> Signed-off-by: David Rochberg (rochberg@chromium.org)
>> BUG=chromiumos:7716
>> TEST=stty tostop, then run with and without this change.  Without the
>> change,
>> tests will hang in a SIGTTOU/syscall-restarted loop.
>>
>> Change-Id: Ib5317e238b68089d71e8e57418717e7553fd64d9
>>
>> Please review this at http://codereview.chromium.org/6368022/
>>
>> SVN Base: ssh://git@gitrw.chromium.org:9222/autotest.git@master
>>
>> Affected files:
>>  M server/autoserv
>>
>>
>> Index: server/autoserv
>> diff --git a/server/autoserv b/server/autoserv
>> index
>>
b3e900b3396724771a357c76f6c6f27a0668f932..8b3d8703b96fdf442541b4e4f07fd563caef74cd
>> 100755
>> --- a/server/autoserv
>> +++ b/server/autoserv
>> @@ -53,6 +53,9 @@ def run_autoserv(pid_file_manager, results, parser):
>>     # Set signal handler
>>     signal.signal(signal.SIGTERM, handle_sigterm)
>>
>> +    # Ignore SIGTTOU in case we are run in a terminal that sets tostop
>> +    signal.signal(signal.SIGTTOU, signal.SIG_IGN)
>> +
>>     # Server side tests that call shell scripts often depend on $USER
>> being set
>>     # but depending on how you launch your autotest scheduler it may not
>> be set.
>>     os.environ['USER'] = getpass.getuser()
>>
>>
>>
>
>
> --
> Eric Li
> 李咏竹
> Google Kirkland
>
>
>

[petkov, 2011-02-01 18:48:27]

LGTM

Consider upstreaming by sending a patch to autotest@test.kernel.org

[ericli, 2011-02-01 19:10:08]

LGTM2.

+1 for please upstream it and I could help you if you need me.

On Tue, Feb 1, 2011 at 10:48 AM, <petkov@chromium.org> wrote:

> LGTM
>
> Consider upstreaming by sending a patch to autotest@test.kernel.org
>
>
> http://codereview.chromium.org/6368022/
>



-- 
Eric Li
李咏竹
Google Kirkland