Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: src/top.h

Issue 6368019: Better name for ShouldReturnException which actually should be ShouldReportException. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/top.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 MessageLocation* location = NULL); 379 MessageLocation* location = NULL);
380 static void ScheduleThrow(Object* exception); 380 static void ScheduleThrow(Object* exception);
381 static void ReportPendingMessages(); 381 static void ReportPendingMessages();
382 static Failure* ThrowIllegalOperation(); 382 static Failure* ThrowIllegalOperation();
383 383
384 // Promote a scheduled exception to pending. Asserts has_scheduled_exception. 384 // Promote a scheduled exception to pending. Asserts has_scheduled_exception.
385 static Failure* PromoteScheduledException(); 385 static Failure* PromoteScheduledException();
386 static void DoThrow(MaybeObject* exception, 386 static void DoThrow(MaybeObject* exception,
387 MessageLocation* location, 387 MessageLocation* location,
388 const char* message); 388 const char* message);
389 static bool ShouldReturnException(bool* is_caught_externally, 389 // Checks if exception should be reported and finds out if it's
390 // caught externally.
391 static bool ShouldReportException(bool* is_caught_externally,
390 bool catchable_by_javascript); 392 bool catchable_by_javascript);
391 393
392 // Attempts to compute the current source location, storing the 394 // Attempts to compute the current source location, storing the
393 // result in the target out parameter. 395 // result in the target out parameter.
394 static void ComputeLocation(MessageLocation* target); 396 static void ComputeLocation(MessageLocation* target);
395 397
396 // Override command line flag. 398 // Override command line flag.
397 static void TraceException(bool flag); 399 static void TraceException(bool flag);
398 400
399 // Out of resource exception helpers. 401 // Out of resource exception helpers.
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 static void Unlock() { Top::break_access_->Unlock(); } 590 static void Unlock() { Top::break_access_->Unlock(); }
589 591
590 static bool TryLock() { 592 static bool TryLock() {
591 return Top::break_access_->TryLock(); 593 return Top::break_access_->TryLock();
592 } 594 }
593 }; 595 };
594 596
595 } } // namespace v8::internal 597 } } // namespace v8::internal
596 598
597 #endif // V8_TOP_H_ 599 #endif // V8_TOP_H_
OLDNEW
« no previous file with comments | « no previous file | src/top.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698