Issue 6368018: Fix web resource server so that it points at the topic for the new promo....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6368018: Fix web resource server so that it points at the topic for the new promo.... (Closed)

Created:
9 years, 11 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix web resource server so that it points at the topic for the new promo. BUG=68672 TEST=manual; ask me for details. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72556

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/web_resource/web_resource_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

9 years, 11 months ago (2011-01-26 00:34:16 UTC) #2

LGTM
erik








On Tue, Jan 25, 2011 at 14:21,  <mirandac@chromium.org> wrote:
> Reviewers: arv,
>
> Message:
> TBR -- just a server change.
>
> Description:
> Fix web resource server so that it points at the topic for the new promo.
>
> BUG=68672
> TEST=manual; ask me for details.
>
> Please review this at http://codereview.chromium.org/6368018/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/web_resource/web_resource_service.cc
>
>
> Index: chrome/browser/web_resource/web_resource_service.cc
> ===================================================================
> --- chrome/browser/web_resource/web_resource_service.cc (revision 72489)
> +++ chrome/browser/web_resource/web_resource_service.cc (working copy)
> @@ -221,7 +221,7 @@
>  // Server for dynamically loaded NTP HTML elements. TODO(mirandac): append
>  // locale for future usage, when we're serving localizable strings.
>  const char* WebResourceService::kDefaultWebResourceServer =
> -    "https://www.google.com/support/chrome/bin/topic/30248/inproduct";
> +    "https://www.google.com/support/chrome/bin/topic/1142433/inproduct";
>
>  WebResourceService::WebResourceService(Profile* profile)
>     : prefs_(profile->GetPrefs()),
>
>
>

Expand Messages | Collapse Messages