Issue 6368013: Port changes from x64 deoptimizer to ia32 and remove commented out code from ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6368013: Port changes from x64 deoptimizer to ia32 and remove commented out code from ... (Closed)

Created:
9 years, 11 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Port changes from x64 deoptimizer to ia32 and remove commented out code from last patch. Committed: http://code.google.com/p/v8/source/detail?r=6451

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
	M	src/ia32/deoptimizer-ia32.cc	View		1 chunk	+6 lines, -7 lines	2 comments	Download
	M	src/x64/deoptimizer-x64.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

I could have also popped the xmm registers (by using two pops), but I think ...

9 years, 11 months ago (2011-01-25 08:40:57 UTC) #1

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/6368013/diff/1/src/ia32/deoptimizer-ia32.cc File src/ia32/deoptimizer-ia32.cc (right): http://codereview.chromium.org/6368013/diff/1/src/ia32/deoptimizer-ia32.cc#newcode537 src/ia32/deoptimizer-ia32.cc:537: for (int i = kNumberOfRegisters -1; i >= ...

9 years, 11 months ago (2011-01-25 08:54:35 UTC) #2

Rico

9 years, 11 months ago (2011-01-25 08:58:59 UTC) #3

http://codereview.chromium.org/6368013/diff/1/src/ia32/deoptimizer-ia32.cc
File src/ia32/deoptimizer-ia32.cc (right):

http://codereview.chromium.org/6368013/diff/1/src/ia32/deoptimizer-ia32.cc#ne...
src/ia32/deoptimizer-ia32.cc:537: for (int i = kNumberOfRegisters -1; i >= 0;
i--) {
On 2011/01/25 08:54:35, Kevin Millikin wrote:
> Space needed in "-1".

Done.

Expand Messages | Collapse Messages