Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7317)

Unified Diff: chrome/browser/tab_contents/web_navigation_observer.h

Issue 6368011: Clean up WebNavigationObserver by taking out password specific callbacks, and... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.cc ('k') | chrome/browser/translate/translate_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/web_navigation_observer.h
===================================================================
--- chrome/browser/tab_contents/web_navigation_observer.h (revision 71973)
+++ chrome/browser/tab_contents/web_navigation_observer.h (working copy)
@@ -6,20 +6,14 @@
#define CHROME_BROWSER_TAB_CONTENTS_WEB_NAVIGATION_OBSERVER_H_
#include "chrome/browser/tab_contents/navigation_controller.h"
+#include "ipc/ipc_channel.h"
struct ViewHostMsg_FrameNavigate_Params;
// An observer API implemented by classes which are interested in various page
-// load events from TabContents.
-
-// TODO(pink): Is it worth having a bitfield where certain clients can only
-// register for certain events? Is the extra function call worth the added pain
-// on the caller to build the bitfield?
-
-class WebNavigationObserver {
+// load events from TabContents. They also get a chance to filter IPC messages.
+class WebNavigationObserver : public IPC::Channel::Listener {
public:
- // For removing PasswordManager deps...
-
virtual void NavigateToPendingEntry() { }
virtual void DidNavigateMainFramePostCommit(
@@ -32,13 +26,8 @@
virtual void DidStartLoading() { }
virtual void DidStopLoading() { }
- // TODO(beng): These should move from here once PasswordManager is able to
- // establish its own private communication protocol to the
- // renderer.
- virtual void PasswordFormsFound(
- const std::vector<webkit_glue::PasswordForm>& forms) { }
- virtual void PasswordFormsVisible(
- const std::vector<webkit_glue::PasswordForm>& visible_forms) { }
+ // IPC::Channel::Listener implementation.
+ virtual bool OnMessageReceived(const IPC::Message& message) { return false; }
#if 0
// For unifying with delegate...
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.cc ('k') | chrome/browser/translate/translate_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698