Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9335)

Unified Diff: chrome/browser/tab_contents/tab_contents.h

Issue 6368011: Clean up WebNavigationObserver by taking out password specific callbacks, and... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/tab_contents.h
===================================================================
--- chrome/browser/tab_contents/tab_contents.h (revision 71973)
+++ chrome/browser/tab_contents/tab_contents.h (working copy)
@@ -55,10 +55,6 @@
class PrintViewManager;
}
-namespace webkit_glue {
-struct PasswordForm;
-}
-
class AutocompleteHistoryManager;
class AutoFillManager;
class BlockedContentContainer;
@@ -743,6 +739,9 @@
// Opens view-source tab for this contents.
void ViewSource();
+ // Notification that translation has started for this tab.
+ void TranslateStarted();
+
// Gets the minimum/maximum zoom percent.
int minimum_zoom_percent() const { return minimum_zoom_percent_; }
int maximum_zoom_percent() const { return maximum_zoom_percent_; }
@@ -752,7 +751,6 @@
AutocompleteHistoryManager* autocomplete_history_manager() {
return autocomplete_history_manager_.get();
}
- AutoFillManager* autofill_manager() { return autofill_manager_.get(); }
protected:
// from RenderViewHostDelegate.
@@ -767,6 +765,7 @@
FRIEND_TEST_ALL_PREFIXES(TabContentsTest, NoJSMessageOnInterstitials);
FRIEND_TEST_ALL_PREFIXES(TabContentsTest, UpdateTitle);
FRIEND_TEST_ALL_PREFIXES(TabContentsTest, CrossSiteCantPreemptAfterUnload);
+ FRIEND_TEST_ALL_PREFIXES(FormStructureBrowserTest, HTMLFiles);
// Temporary until the view/contents separation is complete.
friend class TabContentsView;
@@ -1014,10 +1013,6 @@
virtual void ShowModalHTMLDialog(const GURL& url, int width, int height,
const std::string& json_arguments,
IPC::Message* reply_msg);
- virtual void PasswordFormsFound(
- const std::vector<webkit_glue::PasswordForm>& forms);
- virtual void PasswordFormsVisible(
- const std::vector<webkit_glue::PasswordForm>& visible_forms);
virtual void PageHasOSDD(RenderViewHost* render_view_host,
int32 page_id,
const GURL& url,
@@ -1349,9 +1344,6 @@
// (full-page plugins for now only) permissions.
int content_restrictions_;
- // All the IPC message filters for this render view.
- std::vector<IPC::Channel::Listener*> message_filters_;
-
DISALLOW_COPY_AND_ASSIGN(TabContents);
};

Powered by Google App Engine
This is Rietveld 408576698