Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 6368009: ARM: Implement StringLength and StringCharCodeAt in the lithium-arm (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comments Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1707 matching lines...) Expand 10 before | Expand all | Expand 10 after
1718 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) { 1718 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
1719 LOperand* obj = UseFixed(instr->object(), r1); 1719 LOperand* obj = UseFixed(instr->object(), r1);
1720 LOperand* val = UseFixed(instr->value(), r0); 1720 LOperand* val = UseFixed(instr->value(), r0);
1721 1721
1722 LInstruction* result = new LStoreNamedGeneric(obj, val); 1722 LInstruction* result = new LStoreNamedGeneric(obj, val);
1723 return MarkAsCall(result, instr); 1723 return MarkAsCall(result, instr);
1724 } 1724 }
1725 1725
1726 1726
1727 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) { 1727 LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) {
1728 Abort("LStringCharCodeAt instruction not implemented on ARM"); 1728 LOperand* string = UseRegister(instr->string());
1729 return NULL; 1729 LOperand* index = UseRegisterOrConstant(instr->index());
1730 LInstruction* result = new LStringCharCodeAt(string, index);
1731 return AssignEnvironment(AssignPointerMap(DefineAsRegister(result)));
1730 } 1732 }
1731 1733
1732 1734
1733 LInstruction* LChunkBuilder::DoStringLength(HStringLength* instr) { 1735 LInstruction* LChunkBuilder::DoStringLength(HStringLength* instr) {
1734 Abort("LStringLength instruction not implemented on ARM"); 1736 LOperand* string = UseRegisterAtStart(instr->value());
1735 return NULL; 1737 return DefineAsRegister(new LStringLength(string));
1736 } 1738 }
1737 1739
1738 1740
1739 LInstruction* LChunkBuilder::DoArrayLiteral(HArrayLiteral* instr) { 1741 LInstruction* LChunkBuilder::DoArrayLiteral(HArrayLiteral* instr) {
1740 return MarkAsCall(DefineFixed(new LArrayLiteral, r0), instr); 1742 return MarkAsCall(DefineFixed(new LArrayLiteral, r0), instr);
1741 } 1743 }
1742 1744
1743 1745
1744 LInstruction* LChunkBuilder::DoObjectLiteral(HObjectLiteral* instr) { 1746 LInstruction* LChunkBuilder::DoObjectLiteral(HObjectLiteral* instr) {
1745 return MarkAsCall(DefineFixed(new LObjectLiteral, r0), instr); 1747 return MarkAsCall(DefineFixed(new LObjectLiteral, r0), instr);
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
1867 1869
1868 1870
1869 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 1871 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
1870 HEnvironment* outer = current_block_->last_environment()->outer(); 1872 HEnvironment* outer = current_block_->last_environment()->outer();
1871 current_block_->UpdateEnvironment(outer); 1873 current_block_->UpdateEnvironment(outer);
1872 return NULL; 1874 return NULL;
1873 } 1875 }
1874 1876
1875 1877
1876 } } // namespace v8::internal 1878 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.h ('k') | src/arm/lithium-codegen-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698