Issue 6368009: ARM: Implement StringLength and StringCharCodeAt in the lithium-arm

Issue 6368009: ARM: Implement StringLength and StringCharCodeAt in the lithium-arm (Closed)

Created:
9 years, 11 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

ARM: Implement StringLength and StringCharCodeAt in the lithium-arm backend. Committed: http://code.google.com/p/v8/source/detail?r=6419

Patch Set 2 : Address comments #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -17 lines)			Patch
M	src/arm/lithium-arm.h	View		4 chunks	+26 lines, -0 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	1 chunk	+137 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1	2 chunks	+14 lines, -11 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/6368009/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6368009/diff/1/src/arm/lithium-codegen-arm.cc#newcode2849 src/arm/lithium-codegen-arm.cc:2849: if (index.is_valid()) { Checking instr->index()->IsConstantOperand() instead of index.is_valid() ...

9 years, 11 months ago (2011-01-20 12:56:41 UTC) #2

Mads Ager (chromium)

9 years, 11 months ago (2011-01-20 14:07:52 UTC) #3

http://codereview.chromium.org/6368009/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6368009/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:2849: if (index.is_valid()) {
On 2011/01/20 12:56:41, Søren Gjesse wrote:
> Checking instr->index()->IsConstantOperand() instead of index.is_valid() seems
> more clear.

Done.

http://codereview.chromium.org/6368009/diff/1/src/arm/lithium-codegen-arm.cc#...
src/arm/lithium-codegen-arm.cc:2864: if (index.is_valid()) {
On 2011/01/20 12:56:41, Søren Gjesse wrote:
> Ditto.

Done.

http://codereview.chromium.org/6368009/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/6368009/diff/1/src/ia32/lithium-codegen-ia32.c...
src/ia32/lithium-codegen-ia32.cc:2713: if (index.is_valid()) {
On 2011/01/20 12:56:41, Søren Gjesse wrote:
> instr->index()->IsConstantOperand()?

Done.

http://codereview.chromium.org/6368009/diff/1/src/ia32/lithium-codegen-ia32.c...
src/ia32/lithium-codegen-ia32.cc:2728: if (index.is_valid()) {
On 2011/01/20 12:56:41, Søren Gjesse wrote:
> Ditto.

Done.

Expand Messages | Collapse Messages