Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 6368007: Fix an assertion failure in the full code generator. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix an assertion failure in the full code generator. We hit an assertion failure when we tried to record the AST ID of the (shared) .arguments variable proxy more than once. This was hit when we had multiple calls to the same parameter in a function that used the arguments object. The fix is to not visit the subexpressions of the (shared) property access expression. BUG=1060 Committed: http://code.google.com/p/v8/source/detail?r=6404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -21 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +15 lines, -7 lines 0 comments Download
A test/mjsunit/regress/regress-1060.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
The assertion failure was benign in this case, because the subexpressions (object is a stack ...
9 years, 11 months ago (2011-01-19 14:38:59 UTC) #1
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-19 14:49:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698