Issue 6368002: Fix widget pepper interface crashing after r71544.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6368002: Fix widget pepper interface crashing after r71544. (Closed)

Created:
9 years, 11 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix widget pepper interface crashing after r71544. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71628

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	webkit/plugins/ppapi/ppb_widget_impl.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	webkit/plugins/ppapi/ppb_widget_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

9 years, 11 months ago (2011-01-18 03:55:50 UTC) #2

Whoops, LGTM

On Mon, Jan 17, 2011 at 5:43 PM,  <jam@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Fix widget pepper interface crashing after r71544.
>
> Please review this at http://codereview.chromium.org/6368002/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/plugins/ppapi/ppb_widget_impl.h
>  M     webkit/plugins/ppapi/ppb_widget_impl.cc
>
>
> Index: webkit/plugins/ppapi/ppb_widget_impl.cc
> ===================================================================
> --- webkit/plugins/ppapi/ppb_widget_impl.cc     (revision 71581)
> +++ webkit/plugins/ppapi/ppb_widget_impl.cc     (working copy)
> @@ -100,7 +100,7 @@
>   if (!widget)
>     return;
>   ScopedResourceId resource(this);
> -  widget->Invalidate(instance_->pp_instance(), resource.id, dirty);
> +  widget->Invalidate(instance()->pp_instance(), resource.id, dirty);
>  }
>
>  }  // namespace ppapi
> Index: webkit/plugins/ppapi/ppb_widget_impl.h
> ===================================================================
> --- webkit/plugins/ppapi/ppb_widget_impl.h      (revision 71581)
> +++ webkit/plugins/ppapi/ppb_widget_impl.h      (working copy)
> @@ -39,14 +39,12 @@
>
>   // Notifies the plugin instance that the given rect needs to be repainted.
>   void Invalidate(const PP_Rect* dirty);
> -  PluginInstance* instance() { return instance_; }
>
>  protected:
>   virtual void SetLocationInternal(const PP_Rect* location) = 0;
>   PP_Rect location() const { return location_; }
>
>  private:
> -  scoped_refptr<PluginInstance> instance_;
>   PP_Rect location_;
>
>   DISALLOW_COPY_AND_ASSIGN(PPB_Widget_Impl);
>
>
>

Expand Messages | Collapse Messages