Adding support for JavaScript internationalization API as V8 extension. See p...

Adding support for JavaScript internationalization API as V8 extension. See proposal at http://wiki.ecmascript.org/doku.php?id=strawman:i18n_api.

V8 hosts the actual extension code under src/extensions/experimental/i18n-extension.{cc,h}.

This CL passes command line switches to WebKit (disabled by default) and test shell (enabled by default), using WebRuntimeFeatures. It also sets some gyp variables to point to ICU source path, and defines a guard for a new feature.

It should be submitted only after corresponding WebKit CL (https://bugs.webkit.org/show_bug.cgi?id=49414) lands.

BUG=28604
TEST=LayoutTests/fast/js/i18n-bindings-locale.html


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74491

[Nebojša Ćirić, 2011-01-27 22:42:20]

This is a final piece to the i18n APIs plumbing effort. I'll put it to the bots
and submit once webkit change lands and we do the webkit roll.

[jungshik at Google, 2011-01-27 23:49:47]

lgtm !

http://codereview.chromium.org/6366021/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/6366021/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:527: const char kEnableJavaScriptI18NAPI[]     
 = "enable-experimental-js-i18n-api";
nit:
flag name, variable names and webkit feature flag are all slightly different
(with / without epxerimental, with or without javascript etc). It may be a bit
confusing.

I like {enable, javascript, i18n, api}, but WebkitFeature (upstream change) uses
{enable, experimental, i18n, api}.  Maybe, we'd better be consistent and use
that everywhere (although having JavaScript  would be better). 

Anyway, it's not that important and it's up to you.

[Nebojša Ćirić, 2011-02-10 00:31:21]

WebKit and Chromium have enable-javascript-i18n-api now in all places (define
guard and command line flags).

I am waiting for webkit roll to do try bot run and submit this one.

On 2011/01/27 23:49:47, Jungshik Shin wrote:
> lgtm !
> 
> http://codereview.chromium.org/6366021/diff/1/chrome/common/chrome_switches.cc
> File chrome/common/chrome_switches.cc (right):
> 
>
http://codereview.chromium.org/6366021/diff/1/chrome/common/chrome_switches.c...
> chrome/common/chrome_switches.cc:527: const char kEnableJavaScriptI18NAPI[]   
 
>  = "enable-experimental-js-i18n-api";
> nit:
> flag name, variable names and webkit feature flag are all slightly different
> (with / without epxerimental, with or without javascript etc). It may be a bit
> confusing.
> 
> I like {enable, javascript, i18n, api}, but WebkitFeature (upstream change)
uses
> {enable, experimental, i18n, api}.  Maybe, we'd better be consistent and use
> that everywhere (although having JavaScript  would be better). 
> 
> Anyway, it's not that important and it's up to you.

[jungshik at Google, 2011-02-10 19:31:31]

On 2011/02/10 00:31:21, Nebojša Ćirić wrote:
> WebKit and Chromium have enable-javascript-i18n-api now in all places (define
> guard and command line flags).

Great !
> 
> I am waiting for webkit roll to do try bot run and submit this one.
> 
> On 2011/01/27 23:49:47, Jungshik Shin wrote:
> > lgtm !
> > 
> >
http://codereview.chromium.org/6366021/diff/1/chrome/common/chrome_switches.cc
> > File chrome/common/chrome_switches.cc (right):
> > 
> >
>
http://codereview.chromium.org/6366021/diff/1/chrome/common/chrome_switches.c...
> > chrome/common/chrome_switches.cc:527: const char kEnableJavaScriptI18NAPI[] 
 
>  
> >  = "enable-experimental-js-i18n-api";
> > nit:
> > flag name, variable names and webkit feature flag are all slightly different
> > (with / without epxerimental, with or without javascript etc). It may be a
bit
> > confusing.
> > 
> > I like {enable, javascript, i18n, api}, but WebkitFeature (upstream change)
> uses
> > {enable, experimental, i18n, api}.  Maybe, we'd better be consistent and use
> > that everywhere (although having JavaScript  would be better). 
> > 
> > Anyway, it's not that important and it's up to you.