Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Side by Side Diff: chrome/common/extensions/update_manifest.cc

Issue 6366019: Part 1 of repairing regressions to my old clang check plugins so Nico can (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove Nico's changes that I patched in for testing. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/update_manifest.h" 5 #include "chrome/common/extensions/update_manifest.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/scoped_ptr.h" 9 #include "base/scoped_ptr.h"
10 #include "base/stl_util-inl.h" 10 #include "base/stl_util-inl.h"
11 #include "base/string_util.h" 11 #include "base/string_util.h"
12 #include "base/string_number_conversions.h" 12 #include "base/string_number_conversions.h"
13 #include "base/stringprintf.h" 13 #include "base/stringprintf.h"
14 #include "base/version.h" 14 #include "base/version.h"
15 #include "chrome/common/libxml_utils.h" 15 #include "chrome/common/libxml_utils.h"
16 #include "libxml/tree.h" 16 #include "libxml/tree.h"
17 17
18 static const char* kExpectedGupdateProtocol = "2.0"; 18 static const char* kExpectedGupdateProtocol = "2.0";
19 static const char* kExpectedGupdateXmlns = 19 static const char* kExpectedGupdateXmlns =
20 "http://www.google.com/update2/response"; 20 "http://www.google.com/update2/response";
21 21
22 UpdateManifest::Result::Result() {}
23
24 UpdateManifest::Result::~Result() {}
25
22 UpdateManifest::Results::Results() : daystart_elapsed_seconds(kNoDaystart) {} 26 UpdateManifest::Results::Results() : daystart_elapsed_seconds(kNoDaystart) {}
23 27
24 UpdateManifest::Results::~Results() {} 28 UpdateManifest::Results::~Results() {}
25 29
26 UpdateManifest::UpdateManifest() { 30 UpdateManifest::UpdateManifest() {
27 } 31 }
28 32
29 UpdateManifest::~UpdateManifest() {} 33 UpdateManifest::~UpdateManifest() {}
30 34
31 void UpdateManifest::ParseError(const char* details, ...) { 35 void UpdateManifest::ParseError(const char* details, ...) {
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 std::string error; 258 std::string error;
255 if (!ParseSingleAppTag(apps[i], gupdate_ns, &current, &error)) { 259 if (!ParseSingleAppTag(apps[i], gupdate_ns, &current, &error)) {
256 ParseError("%s", error.c_str()); 260 ParseError("%s", error.c_str());
257 } else { 261 } else {
258 results_.list.push_back(current); 262 results_.list.push_back(current);
259 } 263 }
260 } 264 }
261 265
262 return true; 266 return true;
263 } 267 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698