Part 1 of repairing regressions to my old clang check plugins so Nico can

chrome/browser/browsing_data_indexed_db_helper.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BROWSING_DATA_INDEXED_DB_HELPER_H_
 #define CHROME_BROWSER_BROWSING_DATA_INDEXED_DB_HELPER_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 19 matching lines @@
   // Contains detailed information about an indexed database.
   struct IndexedDBInfo {
     IndexedDBInfo(
         const std::string& protocol,
         const std::string& host,
         unsigned short port,
         const std::string& database_identifier,
         const std::string& origin,
         const FilePath& file_path,
         int64 size,
-        base::Time last_modified)
-        : protocol(protocol),
-          host(host),
-          port(port),
-          database_identifier(database_identifier),
-          origin(origin),
-          file_path(file_path),
-          size(size),
-          last_modified(last_modified) {
-    }
+        base::Time last_modified);
+    ~IndexedDBInfo();
 
-    bool IsFileSchemeData() {
-      return protocol == chrome::kFileScheme;

[Nico, 2011/01/27 03:55:17]

does your plugin warn on this? This looks pretty harmless to me.

[Elliot Glaysher, 2011/01/27 18:48:05]

No, it didn't. I just did it for consistency with the other classes I did this
to. I agree that this is harmless. Undone.

-    }
+    bool IsFileSchemeData();
 
     std::string protocol;
     std::string host;
     unsigned short port;
     std::string database_identifier;
     std::string origin;
     FilePath file_path;
     int64 size;
     base::Time last_modified;
   };
@@ skipping 48 matching lines @@
   virtual ~CannedBrowsingDataIndexedDBHelper();
 
   Profile* profile_;
 
   std::vector<IndexedDBInfo> indexed_db_info_;
 
   DISALLOW_COPY_AND_ASSIGN(CannedBrowsingDataIndexedDBHelper);
 };
 
 #endif  // CHROME_BROWSER_BROWSING_DATA_INDEXED_DB_HELPER_H_