Part 1 of repairing regressions to my old clang check plugins so Nico can

chrome/browser/browsing_data_database_helper.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BROWSING_DATA_DATABASE_HELPER_H_
 #define CHROME_BROWSER_BROWSING_DATA_DATABASE_HELPER_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 11 matching lines @@
 // A client of this class need to call StartFetching from the UI thread to
 // initiate the flow, and it'll be notified by the callback in its UI
 // thread at some later point.
 // The client must call CancelNotification() if it's destroyed before the
 // callback is notified.
 class BrowsingDataDatabaseHelper
     : public base::RefCountedThreadSafe<BrowsingDataDatabaseHelper> {
  public:
   // Contains detailed information about a web database.
   struct DatabaseInfo {
-    DatabaseInfo() {}
+    DatabaseInfo();
     DatabaseInfo(const std::string& host,
                  const std::string& database_name,
                  const std::string& origin_identifier,
                  const std::string& description,
                  const std::string& origin,
                  int64 size,
-                 base::Time last_modified)
-        : host(host),
-          database_name(database_name),
-          origin_identifier(origin_identifier),
-          description(description),
-          origin(origin),
-          size(size),
-          last_modified(last_modified) {
-    }
+                 base::Time last_modified);
+    ~DatabaseInfo();
 
-    bool IsFileSchemeData() {
-      return StartsWithASCII(origin_identifier,
-                             std::string(chrome::kFileScheme),
-                             true);
-    }
+    bool IsFileSchemeData();
 
     std::string host;
     std::string database_name;
     std::string origin_identifier;
     std::string description;
     std::string origin;
     int64 size;
     base::Time last_modified;
   };
 
@@ skipping 72 matching lines @@
       Callback1<const std::vector<DatabaseInfo>& >::Type* callback);
   virtual void CancelNotification() {}
 
  private:
   virtual ~CannedBrowsingDataDatabaseHelper() {}
 
   DISALLOW_COPY_AND_ASSIGN(CannedBrowsingDataDatabaseHelper);
 };
 
 #endif  // CHROME_BROWSER_BROWSING_DATA_DATABASE_HELPER_H_