src/x64/assembler-x64-inl.h - Issue 6366010: X64 Crankshaft: Added a bunch of operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64-inl.h

Issue 6366010: X64 Crankshaft: Added a bunch of operations. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge/build-x64

Patch Set: Address review comments. Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/assembler-x64-inl.h

diff --git a/src/x64/assembler-x64-inl.h b/src/x64/assembler-x64-inl.h

index 70b40e07c8ff00005a836867fe0781e2a14354a5..440645222ffc83e909914366046cadfbbff8c04b 100644

--- a/src/x64/assembler-x64-inl.h

+++ b/src/x64/assembler-x64-inl.h

@@ -425,7 +425,7 @@ void Operand::set_sib(ScaleFactor scale, Register index, Register base) {

// Use SIB with no index register only for base rsp or r12. Otherwise we

// would skip the SIB byte entirely.

ASSERT(!index.is(rsp) || base.is(rsp) || base.is(r12));

- buf_[1] = scale << 6 | index.low_bits() << 3 | base.low_bits();

+ buf_[1] = (scale << 6) | (index.low_bits() << 3) | base.low_bits();

rex_ |= index.high_bit() << 1 | base.high_bit();

len_ = 2;

}

« no previous file with comments | « src/x64/assembler-x64.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »