Issue 6366008: views: Move implementations of ComboboxExample and SliderExample to source file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6366008: views: Move implementations of ComboboxExample and SliderExample to source file. (Closed)

Created:
9 years, 11 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

views: Move implementations of ComboboxExample and SliderExample to source file. BUG=None TEST=run out/Debug/views_examples, everything should works as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72328

Patch Set 1 : #

Patch Set 2 : fix win bot? #

Patch Set 3 : more includes #

Patch Set 4 : Slider is only implemented in gtk #

Total comments: 2

Patch Set 5 : next line #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -72 lines)			Patch
M	views/examples/combobox_example.h	View	1 2 3 4	2 chunks	+11 lines, -46 lines	0 comments	Download
A	views/examples/combobox_example.cc	View		1 chunk	+63 lines, -0 lines	0 comments	Download
M	views/examples/slider_example.h	View	1 2	3 chunks	+13 lines, -26 lines	0 comments	Download
A	views/examples/slider_example.cc	View	1 2 3	1 chunk	+39 lines, -0 lines	0 comments	Download
M	views/views.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

oshima

lgtm http://codereview.chromium.org/6366008/diff/13001/views/examples/combobox_example.h File views/examples/combobox_example.h (right): http://codereview.chromium.org/6366008/diff/13001/views/examples/combobox_example.h#newcode16 views/examples/combobox_example.h:16: class ComboboxExample : public ExampleBase, public views::Combobox::Listener { ...

9 years, 11 months ago (2011-01-24 04:17:23 UTC) #2

tfarina

9 years, 11 months ago (2011-01-24 12:23:53 UTC) #3

http://codereview.chromium.org/6366008/diff/13001/views/examples/combobox_exa...
File views/examples/combobox_example.h (right):

http://codereview.chromium.org/6366008/diff/13001/views/examples/combobox_exa...
views/examples/combobox_example.h:16: class ComboboxExample : public
ExampleBase, public views::Combobox::Listener {
On 2011/01/24 04:17:23, oshima wrote:
> move Combobox::Listener to next line

Done.

Expand Messages | Collapse Messages