Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: chrome/browser/dom_ui/bug_report_ui.cc

Issue 6366007: Disable sending of page title in Chrome reports. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments incorporated. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/bug_report_data.h ('K') | « chrome/browser/bug_report_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/bug_report_ui.cc
diff --git a/chrome/browser/dom_ui/bug_report_ui.cc b/chrome/browser/dom_ui/bug_report_ui.cc
index bd4bd15b8969306953339577c41a0e24fb0beadd..7bbe986143c61fb9b9d78457ac17d524df6b6617 100644
--- a/chrome/browser/dom_ui/bug_report_ui.cc
+++ b/chrome/browser/dom_ui/bug_report_ui.cc
@@ -227,7 +227,6 @@ class BugReportHandler : public DOMMessageHandler,
DOMUIScreenshotSource* screenshot_source_;
BugReportData* bug_report_;
- string16 target_tab_title_;
std::string target_tab_url_;
#if defined(OS_CHROMEOS)
// Variables to track SyslogsLibrary::RequestSyslogs callback.
@@ -406,7 +405,6 @@ void BugReportData::SendReport() {
char* image_data = image_data_size ?
reinterpret_cast<char*>(&(image_.front())) : NULL;
BugReportUtil::SendReport(profile_
- , UTF16ToUTF8(target_tab_title_)
, problem_type_
, page_url_
, description_
@@ -528,7 +526,8 @@ base::StringPiece BugReportHandler::Init() {
TabContents* target_tab = browser->GetTabContentsAt(index);
if (target_tab) {
- target_tab_title_ = target_tab->GetTitle();
+ // TODO(rkc): Remove target tab title completely once we decide if we
+ // decide if there never is a reason to send it at all.
oshima 2011/01/23 15:16:24 Is this comment still valid?
rkc 2011/01/25 00:00:03 Removed. Done.
target_tab_url_ = target_tab->GetURL().spec();
}
@@ -686,7 +685,6 @@ void BugReportHandler::HandleSendReport(const ListValue* list_value) {
// Update the data in bug_report_ so it can be sent
bug_report_->UpdateData(dom_ui_->GetProfile()
, target_tab_url_
- , target_tab_title_
, problem_type
, page_url
, description
« chrome/browser/bug_report_data.h ('K') | « chrome/browser/bug_report_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698