Tolerate out-of-date plugins for these particular tests, otherwise they...

Tolerate out-of-date plugins for these particular tests, otherwise they
randomly break as out requirement get out of line with the bots.

BUG=68303
TEST=reenabled on Linux


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71732

[Chris Evans, 2011-01-18 23:41:32]

Should enable the test being re-enabled on Linux at least.

[Cris Neckar, 2011-01-18 23:43:56]

LGTM

[Bernhard Bauer, 2011-01-19 07:57:38]

http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test.cpp
File chrome/test/plugin/plugin_test.cpp (right):

http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test....
chrome/test/plugin/plugin_test.cpp:179: // http://crbug.com/68751
Drive-by: http://crbug.com/68751 is marked as fixed, so maybe we should
re-enable them on Mac as well?

[cevans, 2011-01-19 08:39:42]

Ooh! Well spotted. I'll toss in a CL now to see if it passes.

On Tue, Jan 18, 2011 at 11:57 PM, <bauerb@chromium.org> wrote:

>
>
>
http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test.cpp
> File chrome/test/plugin/plugin_test.cpp (right):
>
>
>
http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test....
> chrome/test/plugin/plugin_test.cpp:179: // http://crbug.com/68751
> Drive-by: http://crbug.com/68751 is marked as fixed, so maybe we should
> re-enable them on Mac as well?
>
>
> http://codereview.chromium.org/6365003/
>

[Bernhard Bauer, 2011-01-19 08:57:10]

Thanks!

On Wed, Jan 19, 2011 at 09:39, Chris Evans <cevans@google.com> wrote:
> Ooh! Well spotted. I'll toss in a CL now to see if it passes.
>
> On Tue, Jan 18, 2011 at 11:57 PM, <bauerb@chromium.org> wrote:
>>
>>
>>
http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test.cpp
>> File chrome/test/plugin/plugin_test.cpp (right):
>>
>>
>>
http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test....
>> chrome/test/plugin/plugin_test.cpp:179: // http://crbug.com/68751
>> Drive-by: http://crbug.com/68751 is marked as fixed, so maybe we should
>> re-enable them on Mac as well?
>>
>> http://codereview.chromium.org/6365003/
>
>

[cevans, 2011-01-19 09:36:23]

I think it stuck ok.
I don't see PluginTest on the Mac roster apart from Mac10.6 Perf(3) which
definitely ran the un-disabled tests and passed:
http://build.chromium.org/p/chromium.perf/waterfall?builder=Mac10.6%20Perf%28...

On Wed, Jan 19, 2011 at 12:56 AM, Bernhard Bauer <bauerb@chromium.org>wrote:

> Thanks!
>
> On Wed, Jan 19, 2011 at 09:39, Chris Evans <cevans@google.com> wrote:
> > Ooh! Well spotted. I'll toss in a CL now to see if it passes.
> >
> > On Tue, Jan 18, 2011 at 11:57 PM, <bauerb@chromium.org> wrote:
> >>
> >>
> >>
>
http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test.cpp
> >> File chrome/test/plugin/plugin_test.cpp (right):
> >>
> >>
> >>
>
http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test....
> >> chrome/test/plugin/plugin_test.cpp:179: // http://crbug.com/68751
> >> Drive-by: http://crbug.com/68751 is marked as fixed, so maybe we should
> >> re-enable them on Mac as well?
> >>
> >> http://codereview.chromium.org/6365003/
> >
> >
>

[Bernhard Bauer, 2011-01-19 09:45:57]

Mac10.5 Perf (1) runs them as well, but hasn't finished its last run
yet
(http://build.chromium.org/p/chromium.perf/builders/Mac10.5%20Perf%281%29/buil...).

On Wednesday, January 19, 2011, Chris Evans <cevans@google.com> wrote:
> I think it stuck ok.I don't see PluginTest on the Mac roster apart from
Mac10.6 Perf(3) which definitely ran the un-disabled tests and
passed: http://build.chromium.org/p/chromium.perf/waterfall?builder=Mac10.6%20Perf%283%29
>
> On Wed, Jan 19, 2011 at 12:56 AM, Bernhard Bauer <bauerb@chromium.org> wrote:
>
> Thanks!
>
> On Wed, Jan 19, 2011 at 09:39, Chris Evans <cevans@google.com> wrote:
>> Ooh! Well spotted. I'll toss in a CL now to see if it passes.
>>
>> On Tue, Jan 18, 2011 at 11:57 PM, <bauerb@chromium.org> wrote:
>>>
>>>
>>>
http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test.cpp
>>> File chrome/test/plugin/plugin_test.cpp (right):
>>>
>>>
>>>
http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test....
>>> chrome/test/plugin/plugin_test.cpp:179: // http://crbug.com/68751
>>> Drive-by: http://crbug.com/68751 is marked as fixed, so maybe we should
>>> re-enable them on Mac as well?
>>>
>>> http://codereview.chromium.org/6365003/
>>
>>
>
>
>

[Bernhard Bauer, 2011-01-19 12:11:15]

Mac10.5 Perf (1) runs them as well, but hasn't finished its last run
yet
(http://build.chromium.org/p/chromium.perf/builders/Mac10.5%20Perf%281%29/buil...).

On Wednesday, January 19, 2011, Chris Evans <cevans@google.com> wrote:
> I think it stuck ok.I don't see PluginTest on the Mac roster apart from
Mac10.6 Perf(3) which definitely ran the un-disabled tests and
passed: http://build.chromium.org/p/chromium.perf/waterfall?builder=Mac10.6%20Perf%283%29
>
> On Wed, Jan 19, 2011 at 12:56 AM, Bernhard Bauer <bauerb@chromium.org> wrote:
>
> Thanks!
>
> On Wed, Jan 19, 2011 at 09:39, Chris Evans <cevans@google.com> wrote:
>> Ooh! Well spotted. I'll toss in a CL now to see if it passes.
>>
>> On Tue, Jan 18, 2011 at 11:57 PM, <bauerb@chromium.org> wrote:
>>>
>>>
>>>
http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test.cpp
>>> File chrome/test/plugin/plugin_test.cpp (right):
>>>
>>>
>>>
http://codereview.chromium.org/6365003/diff/1/chrome/test/plugin/plugin_test....
>>> chrome/test/plugin/plugin_test.cpp:179: // http://crbug.com/68751
>>> Drive-by: http://crbug.com/68751 is marked as fixed, so maybe we should
>>> re-enable them on Mac as well?
>>>
>>> http://codereview.chromium.org/6365003/
>>
>>
>
>
>