Issue 6364013: Defered collect DirectX diagnostics until they are needed for about:gpu....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6364013: Defered collect DirectX diagnostics until they are needed for about:gpu.... (Closed)

Created:
9 years, 11 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, pam+watch_chromium.org, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Defered collect DirectX diagnostics until they are needed for about:gpu. This is because collecting the stats often crashes. Added a guard to prevent the collection of diagnostics on multiple threads simultaneously. Renamed GPUInfo::Progress to GPUInfo::Level. TEST=try, about:gpu does not cause concurrent diagnostics collection BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72704

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -50 lines)			Patch
M	chrome/browser/dom_ui/gpu_internals_ui.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/gpu_blacklist.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gpu_blacklist_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gpu_process_host_ui_shim.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gpu_process_host_ui_shim.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/common/gpu_info.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/common/gpu_info.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/common/gpu_info_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/gpu_messages.cc	View	6 chunks	+23 lines, -5 lines	0 comments	Download
M	chrome/common/gpu_messages_internal.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/common/gpu_messages_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/gpu_param_traits.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/gpu/gpu_info_collector_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/gpu/gpu_info_collector_win.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/gpu/gpu_thread.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/gpu/gpu_thread.cc	View	3 chunks	+21 lines, -14 lines	0 comments	Download
M	chrome/test/gpu/gpu_pixel_browsertest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

9 years, 11 months ago (2011-01-26 22:20:22 UTC) #2

LGTM

Will this patch reduce the amount of information we can report in our UMA
histograms?

Expand Messages | Collapse Messages