Issue 6364009: From the enter-passphrase screen in sync setup, canceling should only disable...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6364009: From the enter-passphrase screen in sync setup, canceling should only disable... (Closed)

Created:
9 years, 11 months ago by John Gregg

Modified:
9 years ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

From the enter-passphrase screen in sync setup, canceling should only disable encrypted sync, not all sync. Show a confirmation dialog for the same and ignore future passphrase warnings that are decryption-related, as long as encrypted datatypes are not being used. BUG=60182 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72659

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -7 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View		2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/resources/passphrase.html	View	1	3 chunks	+44 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/sync_setup_flow.h	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/sync/sync_setup_flow.cc	View	1	5 chunks	+24 lines, -4 lines	1 comment	Download
M	chrome/browser/sync/sync_setup_wizard.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

9 years, 11 months ago (2011-01-26 18:41:31 UTC) #2

LGTM

http://codereview.chromium.org/6364009/diff/7001/chrome/browser/sync/sync_set...
File chrome/browser/sync/sync_setup_flow.cc (right):

http://codereview.chromium.org/6364009/diff/7001/chrome/browser/sync/sync_set...
chrome/browser/sync/sync_setup_flow.cc:172: static void
DisablePasswordSync(ProfileSyncService* service) {
at first I didn't like this, then I spent 10 minutes looking at alternatives,
and now I think it's good :)

I made a mental note to somehow remove the Activate/Deactivate data type stuff
from ProfileSyncService, since it has a very specific use case yet adds
confusion every time you go and try to "disable" a data type because there are
seemingly 4 to 5 ways to do it.

Expand Messages | Collapse Messages