Issue 6364007: ARM: Implement DoInstanceOfAndBranch in the lithium code generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6364007: ARM: Implement DoInstanceOfAndBranch in the lithium code generator (Closed)

Created:
9 years, 11 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

ARM: Implement DoInstanceOfAndBranch in the lithium code generator. BUG=none TEST=none

Patch Set 2 : Add fixed input register allocation. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	src/arm/lithium-arm.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/arm/lithium-codegen-arm.cc	View	1	1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

http://codereview.chromium.org/6364007/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6364007/diff/1/src/arm/lithium-codegen-arm.cc#newcode2012 src/arm/lithium-codegen-arm.cc:2012: InstanceofStub stub(InstanceofStub::kArgsInRegisters); Don't you need to change the creation ...

9 years, 11 months ago (2011-01-26 07:38:50 UTC) #2

Karl Klose

9 years, 11 months ago (2011-01-26 20:39:18 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 6364007: ARM: Implement DoInstanceOfAndBranch in the lithium code generator (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add fixed input register allocation. #

Messages