Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 6364006: Fix StatsCounters on mac. (Closed)

Created:
9 years, 11 months ago by tonyg
Modified:
9 years, 6 months ago
Reviewers:
Mike Belshe
CC:
chromium-reviews
Visibility:
Public.

Description

Fix StatsCounters on mac. In order for the shared memory to work, they must all use the same file name which is keyed by the pid of the browser process. Previously the mac code path was using the pid for each process so there was no sharing happening. Now mac uses the same code path as win which properly uses the parent pid for all procs. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72538

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix signed/unsigned compare #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome/app/chrome_main.cc View 1 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tonyg
http://codereview.chromium.org/6364006/diff/1/chrome/app/chrome_main.cc File chrome/app/chrome_main.cc (left): http://codereview.chromium.org/6364006/diff/1/chrome/app/chrome_main.cc#oldcode768 chrome/app/chrome_main.cc:768: #if defined(OS_MACOSX) FYI, this is no functional change. I ...
9 years, 11 months ago (2011-01-24 23:56:55 UTC) #1
Mike Belshe
9 years, 11 months ago (2011-01-25 18:55:19 UTC) #2
lgtm!

Powered by Google App Engine
This is Rietveld 408576698