Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 6364002: Adding build script changes to support LiveObjectList functionality. (Closed)

Created:
9 years, 11 months ago by marklam
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Adding build script changes to support LiveObjectList functionality. Committed: http://code.google.com/p/v8/source/detail?r=6414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M SConstruct View 3 chunks +14 lines, -0 lines 0 comments Download
M src/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 4 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marklam
Replacement for http://codereview.chromium.org/6338009/.
9 years, 11 months ago (2011-01-19 09:44:07 UTC) #1
Søren Thygesen Gjesse
LGTM However, there is an issue building with liveobjectlist=on in release mode scons sample=shell liveobjectlist=on ...
9 years, 11 months ago (2011-01-20 08:39:17 UTC) #2
marklam
9 years, 11 months ago (2011-01-20 15:09:44 UTC) #3
Build issue with mode=release liveobjectlist=on is fixed here:
http://codereview.chromium.org/6267007/

Powered by Google App Engine
This is Rietveld 408576698