Makes chrome pass down the length of text as the end of the

Makes chrome pass down the length of text as the end of the
selection for instant queries. At some point I'll wire through the
actual cursor position, but this is better than what we had.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71509

[tonyg, 2011-01-14 18:53:27]

LGTM

http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
File chrome/browser/instant/instant_browsertest.cc (right):

http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
chrome/browser/instant/instant_browsertest.cc:180: //
window.chrome.searchBox.selectionStart
Optional: I recommend also testing selectionEnd (even though it always matches
selectionStart at the moment. I also recommend testing the beforeLoad version of
each.

http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
File chrome/browser/instant/instant_loader.cc (right):

http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
chrome/browser/instant/instant_loader.cc:99: // TODO: support real cursor
position.
Should we open a tracking bug?

http://codereview.chromium.org/6363001/diff/1/chrome/renderer/searchbox_exten...
File chrome/renderer/searchbox_extension.cc (right):

http://codereview.chromium.org/6363001/diff/1/chrome/renderer/searchbox_exten...
chrome/renderer/searchbox_extension.cc:82: "   
window.chrome.searchBox.selection_start);";
s/selection_start/selectionStart/

[sky, 2011-01-14 19:07:02]

I've done all of these, except testing beforeLoad. Net patch uploaded
if you want to take another look.

  -Scott

On Fri, Jan 14, 2011 at 10:53 AM,  <tonyg@chromium.org> wrote:
> LGTM
>
>
>
http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
> File chrome/browser/instant/instant_browsertest.cc (right):
>
>
http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
> chrome/browser/instant/instant_browsertest.cc:180: //
> window.chrome.searchBox.selectionStart
> Optional: I recommend also testing selectionEnd (even though it always
> matches selectionStart at the moment. I also recommend testing the
> beforeLoad version of each.
>
>
http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
> File chrome/browser/instant/instant_loader.cc (right):
>
>
http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
> chrome/browser/instant/instant_loader.cc:99: // TODO: support real
> cursor position.
> Should we open a tracking bug?
>
>
http://codereview.chromium.org/6363001/diff/1/chrome/renderer/searchbox_exten...
> File chrome/renderer/searchbox_extension.cc (right):
>
>
http://codereview.chromium.org/6363001/diff/1/chrome/renderer/searchbox_exten...
> chrome/renderer/searchbox_extension.cc:82: "
> window.chrome.searchBox.selection_start);";
> s/selection_start/selectionStart/
>
> http://codereview.chromium.org/6363001/
>

[tonyg, 2011-01-14 19:10:33]

LGTM

On Fri, Jan 14, 2011 at 11:06 AM, Scott Violet <sky@chromium.org> wrote:
> I've done all of these, except testing beforeLoad. Net patch uploaded
> if you want to take another look.
>
>  -Scott
>
> On Fri, Jan 14, 2011 at 10:53 AM,  <tonyg@chromium.org> wrote:
>> LGTM
>>
>>
>>
http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
>> File chrome/browser/instant/instant_browsertest.cc (right):
>>
>>
http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
>> chrome/browser/instant/instant_browsertest.cc:180: //
>> window.chrome.searchBox.selectionStart
>> Optional: I recommend also testing selectionEnd (even though it always
>> matches selectionStart at the moment. I also recommend testing the
>> beforeLoad version of each.
>>
>>
http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
>> File chrome/browser/instant/instant_loader.cc (right):
>>
>>
http://codereview.chromium.org/6363001/diff/1/chrome/browser/instant/instant_...
>> chrome/browser/instant/instant_loader.cc:99: // TODO: support real
>> cursor position.
>> Should we open a tracking bug?
>>
>>
http://codereview.chromium.org/6363001/diff/1/chrome/renderer/searchbox_exten...
>> File chrome/renderer/searchbox_extension.cc (right):
>>
>>
http://codereview.chromium.org/6363001/diff/1/chrome/renderer/searchbox_exten...
>> chrome/renderer/searchbox_extension.cc:82: "
>> window.chrome.searchBox.selection_start);";
>> s/selection_start/selectionStart/
>>
>> http://codereview.chromium.org/6363001/
>>
>