Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 6361011: dom-ui settings: Change search regex to not search for word-boundaries to imp... (Closed)

Created:
9 years, 11 months ago by csilv
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

dom-ui settings: Change search regex to not search for word-boundaries to improve searchability and fix unicode searching. BUG=70146 TEST=Verify that search works properly with CJK languages. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72695

Patch Set 1 #

Patch Set 2 : bump copyright date #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/options/search_page.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
csilv
+jhawkins for review
9 years, 11 months ago (2011-01-26 20:39:42 UTC) #1
James Hawkins
9 years, 11 months ago (2011-01-26 20:51:03 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698