Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6361002: Move SystemMonitor to src/chrome/common.... (Closed)

Created:
9 years, 11 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews, Paweł Hajdan Jr., jam, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, native-client-reviews_googlegroups.com, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Move SystemMonitor to src/ui/base/system_monitor. Move HiResTimerManager to src/chrome/common. BUG=none TEST=none TBR=brettw Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71487

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -602 lines) Patch
M app/app.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
M app/app_base.gypi View 1 1 chunk +5 lines, -8 lines 0 comments Download
D app/hi_res_timer_manager.h View 1 chunk +0 lines, -30 lines 0 comments Download
D app/hi_res_timer_manager_posix.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D app/hi_res_timer_manager_win.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D app/system_monitor.h View 1 chunk +0 lines, -139 lines 0 comments Download
D app/system_monitor.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D app/system_monitor_mac.mm View 1 chunk +0 lines, -67 lines 0 comments Download
D app/system_monitor_posix.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D app/system_monitor_unittest.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D app/system_monitor_win.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/browser/browser_main.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/common/hi_res_timer_manager.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + chrome/common/hi_res_timer_manager_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/common/hi_res_timer_manager_win.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/nacl/nacl_main.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/plugin/plugin_main.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/renderer_main.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/utility_main.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/worker/worker_main.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + ui/base/system_monitor/system_monitor.h View 1 3 chunks +8 lines, -4 lines 0 comments Download
A + ui/base/system_monitor/system_monitor.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
A + ui/base/system_monitor/system_monitor_mac.mm View 1 2 chunks +6 lines, -2 lines 0 comments Download
A + ui/base/system_monitor/system_monitor_posix.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
A + ui/base/system_monitor/system_monitor_unittest.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
A + ui/base/system_monitor/system_monitor_win.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M views/widget/widget_win.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ben Goodger (Google)
9 years, 11 months ago (2011-01-14 17:10:27 UTC) #1
sky
LGTM
9 years, 11 months ago (2011-01-14 17:13:51 UTC) #2
Ben Goodger (Google)
9 years, 11 months ago (2011-01-14 19:23:04 UTC) #3
Ben Goodger (Google)
We figured out some ways that my earlier change that sky looked at wouldn't work. ...
9 years, 11 months ago (2011-01-14 19:23:45 UTC) #4
sky
9 years, 11 months ago (2011-01-14 23:15:27 UTC) #5 
LGTM

Powered by Google App Engine
This is Rietveld 408576698