Issue 6360016: dom-ui settings: Improve search field behavior....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6360016: dom-ui settings: Improve search field behavior.... (Closed)

Created:
9 years, 11 months ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews), James Hawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

dom-ui settings: Improve search field behavior. - focus search field by default. - don't show search results page until user starts typing. - focus search field on forward slash if not focused on a control. BUG=69154, 69722 TEST=Verify focusing behavior per above. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72547

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : rebase #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -32 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/dom_ui/options/core_options_handler.cc	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options/options.js	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/resources/options/options_page.js	View	1 2	3 chunks	+25 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/options/search_page.html	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options/search_page.js	View	1 2	5 chunks	+40 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

Erik, I'm going to commit this now based on the LGTM from James and the ...

9 years, 11 months ago (2011-01-25 21:30:22 UTC) #3

LGTM

Expand Messages | Collapse Messages