Removes debugging code as cause of crash was found. I'm TBRing as this

Removes debugging code as cause of crash was found. I'm TBRing as this
just converts some CHECKs to DCHECKs.

BUG=62872
TEST=none
TBR=ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72367

[Ben Goodger (Google), 2011-01-25 17:01:29]

OK

On Mon, Jan 24, 2011 at 9:34 AM, <sky@chromium.org> wrote:

> Reviewers: Ben Goodger,
>
> Description:
> Removes debugging code as cause of crash was found. I'm TBRing as this
> just converts some CHECKs to DCHECKs.
>
> BUG=62872
> TEST=none
> TBR=ben@chromium.org
>
> Please review this at http://codereview.chromium.org/6360015/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M views/controls/menu/menu_controller.cc
>
>
> Index: views/controls/menu/menu_controller.cc
> diff --git a/views/controls/menu/menu_controller.cc
> b/views/controls/menu/menu_controller.cc
> index
>
dbc31a4d7a26b92f77565564cfdb218c00d79eb9..af4c2762735c66a313dfed2fa7b756debd0ba3b6
> 100644
> --- a/views/controls/menu/menu_controller.cc
> +++ b/views/controls/menu/menu_controller.cc
> @@ -745,7 +745,7 @@ void MenuController::SetSelection(MenuItemView*
> menu_item,
>   if (menu_item && menu_item->GetDelegate())
>     menu_item->GetDelegate()->SelectionChanged(menu_item);
>
> -  CHECK(menu_item || (selection_types & SELECTION_EXIT) != 0);
> +  DCHECK(menu_item || (selection_types & SELECTION_EXIT) != 0);
>
>   pending_state_.item = menu_item;
>   pending_state_.submenu_open = (selection_types & SELECTION_OPEN_SUBMENU)
> != 0;
> @@ -1668,7 +1668,7 @@ void MenuController::RepostEvent(SubmenuView* source,
>     // We some times get an event after closing all the menus. Ignore it.
>     // Make sure the menu is in fact not visible. If the menu is visible,
> then
>     // we're in a bad state where we think the menu isn't visibile but it
> is.
> -    CHECK(!source->GetWidget()->IsVisible());
> +    DCHECK(!source->GetWidget()->IsVisible());
>     return;
>   }
>
>
>
>