Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 6360014: views: Move fill_layout.[cc,h] into layout directory. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

views: Move fill_layout.[cc,h] into layout directory. The other layout files under views directory will be moved later. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72428

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -42 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/network_selection_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/options/settings_page_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/info_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_container_views.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/listbox/listbox.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/tabbed_pane/native_tabbed_pane_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/tabbed_pane/native_tabbed_pane_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/examples/button_example.h View 1 3 chunks +2 lines, -3 lines 0 comments Download
views/examples/combobox_example.h View 1 1 chunk +1 line, -1 line 0 comments Download
M views/examples/menu_example.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/examples/table_example.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/examples/throbber_example.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + views/layout/fill_layout.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + views/layout/fill_layout.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M views/views.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/widget/root_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Please, take a look.
9 years, 11 months ago (2011-01-23 02:40:10 UTC) #1
sky
LGTM http://codereview.chromium.org/6360014/diff/1/views/widget/root_view.cc File views/widget/root_view.cc (right): http://codereview.chromium.org/6360014/diff/1/views/widget/root_view.cc#newcode14 views/widget/root_view.cc:14: #include "views/layout/fill_layout.h" after focus
9 years, 11 months ago (2011-01-24 16:15:35 UTC) #2
tfarina
9 years, 11 months ago (2011-01-24 16:30:14 UTC) #3
http://codereview.chromium.org/6360014/diff/1/views/widget/root_view.cc
File views/widget/root_view.cc (right):

http://codereview.chromium.org/6360014/diff/1/views/widget/root_view.cc#newco...
views/widget/root_view.cc:14: #include "views/layout/fill_layout.h"
On 2011/01/24 16:15:35, sky wrote:
> after focus

Done.

Powered by Google App Engine
This is Rietveld 408576698