Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 6360013: DOMUI: Adjust location of "Disable individual plug-ins" link. (Closed)

Created:
9 years, 11 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

DOMUI: Adjust location of "Disable individual plug-ins" link. BUG=70279 TEST=manual, see bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72310

Patch Set 1 #

Patch Set 2 : link class #

Patch Set 3 : only margin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M chrome/browser/resources/options/content_settings.html View 1 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options/options_page.css View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
Please, take a look.
9 years, 11 months ago (2011-01-22 18:36:09 UTC) #1
James Hawkins
Mostly LG, but the link needs better padding. It butts up against the 'Manage Exceptions' ...
9 years, 11 months ago (2011-01-23 22:14:58 UTC) #2
tfarina
On 2011/01/23 22:14:58, James Hawkins wrote: > Mostly LG, but the link needs better padding. ...
9 years, 11 months ago (2011-01-24 01:29:12 UTC) #3
James Hawkins
On 2011/01/24 01:29:12, tfarina wrote: > On 2011/01/23 22:14:58, James Hawkins wrote: > > Mostly ...
9 years, 11 months ago (2011-01-24 01:33:17 UTC) #4
tfarina
On 2011/01/24 01:33:17, James Hawkins wrote: > > It has the same look and feel ...
9 years, 11 months ago (2011-01-24 02:09:22 UTC) #5
James Hawkins
On 2011/01/24 02:09:22, tfarina wrote: > On 2011/01/24 01:33:17, James Hawkins wrote: > > > ...
9 years, 11 months ago (2011-01-24 02:13:25 UTC) #6
tfarina
On 2011/01/24 02:13:25, James Hawkins wrote: > Uploading would have helped, so I could see ...
9 years, 11 months ago (2011-01-24 02:27:43 UTC) #7
James Hawkins
On 2011/01/24 02:27:43, tfarina wrote: > On 2011/01/24 02:13:25, James Hawkins wrote: > > Uploading ...
9 years, 11 months ago (2011-01-24 02:30:21 UTC) #8
tfarina
On 2011/01/24 02:30:21, James Hawkins wrote: > The spacing is the same...make it 10px, then ...
9 years, 11 months ago (2011-01-24 02:36:39 UTC) #9
James Hawkins
On 2011/01/24 02:36:39, tfarina wrote: > On 2011/01/24 02:30:21, James Hawkins wrote: > > The ...
9 years, 11 months ago (2011-01-24 02:38:43 UTC) #10
tfarina
On 2011/01/24 02:38:43, James Hawkins wrote: > Sorry, I'm not communicating well enough. I only ...
9 years, 11 months ago (2011-01-24 02:49:39 UTC) #11
James Hawkins
9 years, 11 months ago (2011-01-24 02:50:13 UTC) #12
On 2011/01/24 02:49:39, tfarina wrote:
> On 2011/01/24 02:38:43, James Hawkins wrote:
> > Sorry, I'm not communicating well enough.  I only want margin-top/bottom, so
> > try:
> > 
> > margin: 10px 0;
> 
> Done, PTAL! One last screenshot: http://i.imgur.com/RxAyJ.png

LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698