Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 6360011: ChromeFrame full tab mode was not supporting the PROPFIND verb correctly, in ... (Closed)

Created:
9 years, 11 months ago by ananta
Modified:
9 years, 6 months ago
CC:
chromium-reviews, amit
Visibility:
Public.

Description

ChromeFrame full tab mode was not supporting the PROPFIND verb correctly, in the sense that these requests can upload data on the same lines as regular HTTP POST and PUT requests. As a result we would end up never sending out the request to the server. Cleaned up the code in our IBindStatusCallback::GetBindInfo implementation to always honor the posted data length associated with the current request and use it to determine whether we have data to upload. Fixes bug http://code.google.com/p/chromium/issues/detail?id=70302 BUG=70302 TEST=As described in the bug at this point. We need to add support in the HTTPTest server to allow the PROPFIND and other custom methods. Will do that in a subsequent CL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72246

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M chrome_frame/urlmon_url_request.cc View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 11 months ago (2011-01-22 00:05:07 UTC) #1
tommi (sloooow) - chröme
9 years, 11 months ago (2011-01-22 00:26:44 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698