Objective-C readability review for Robert Sesek <rsesek@google.com>.

chrome/browser/ui/cocoa/page_info_bubble_controller.h

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/scoped_nsobject.h"
 #include "base/scoped_ptr.h"
 #include "chrome/browser/page_info_model.h"
 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
 
 // This NSWindowController subclass manages the InfoBubbleWindow and view that
 // are displayed when the user clicks the security lock icon.
 @interface PageInfoBubbleController : BaseBubbleController {
  @private
   // The model that generates the content displayed by the controller.
   scoped_ptr<PageInfoModel> model_;
 
   // Thin bridge that pushes model-changed notifications from C++ to Cocoa.
   scoped_ptr<PageInfoModel::PageInfoModelObserver> bridge_;
 
   // The certificate ID for the page, 0 if the page is not over HTTPS.
   int certID_;
 }
 
 @property (nonatomic, assign) int certID;

[pink (ping after 24hrs), 2011/01/24 15:59:11]

no space between @property and (

[Robert Sesek, 2011/01/24 16:39:56]

The style guide doesn't have this, and we use a mix in Chromium. Should we
standardize one of the two and put it in the guide? If so, I'll message
objc-style and put together a CL.

http://google-styleguide.googlecode.com/svn/trunk/objcguide.xml#Properties

Here are the actual usage numbers:
$ git gs "@property (" | wc -l
     188
$ git gs "@property(" | wc -l
     118

[Robert Sesek, 2011/01/24 17:02:42]

Removed.

 
 // Designated initializer. The new instance will take ownership of |model| and
 // |bridge|. There should be a 1:1 mapping of models to bridges. The
 // controller will release itself when the bubble is closed.
 - (id)initWithPageInfoModel:(PageInfoModel*)model
               modelObserver:(PageInfoModel::PageInfoModelObserver*)bridge
                parentWindow:(NSWindow*)parentWindow;

[pink (ping after 24hrs), 2011/01/24 15:59:11]

is |parentWindow| allowed to be nil? What happens if you call showCertWindow and
it is?

[Robert Sesek, 2011/01/24 16:39:56]

Can't be nil and never is in practice. Added a comment and a DCHCECK.

 
 // Shows the certificate display window. Note that this will implicitly close
 // the bubble because the certificate window will become key. The certificate
 // information attaches itself as a sheet to the |parentWindow|.
 - (IBAction)showCertWindow:(id)sender;
 
 // Opens the help center link that explains the contents of the page info.
 - (IBAction)showHelpPage:(id)sender;
 
 @end
 
 @interface PageInfoBubbleController (ExposedForUnitTesting)
 - (void)performLayout;
 @end