Issue 6360002: Remove 'annotations' dictionary in policy_definitions.json.

Issue 6360002: Remove 'annotations' dictionary in policy_definitions.json. (Closed)

Created:
9 years, 11 months ago by Jakob Kummerow

Modified:
9 years, 6 months ago

Reviewers:
gfeher

CC:
chromium-reviews, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove 'annotations' dictionary in policy_definitions.json. The former members of the dict are now included directly in the policy definitions. BUG=64898 TEST=existing unit tests in tools/grit/grit/format/policy_templates/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71635

Patch Set 1 #

Total comments: 4

Patch Set 2 : better comments #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+249 lines, -420 lines)			Patch
M	chrome/app/policy/policy_templates.json	View	1	44 chunks	+202 lines, -314 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/doc_writer.py	View		8 chunks	+8 lines, -9 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py	View	1	11 chunks	+15 lines, -35 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/json_writer.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/json_writer_unittest.py	View		8 chunks	+9 lines, -27 lines	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/reg_writer.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/grit/grit/format/policy_templates/writers/reg_writer_unittest.py	View		9 chunks	+10 lines, -28 lines	0 comments	Download
M	tools/grit/grit/gather/policy_json.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/grit/grit/gather/policy_json_unittest.py	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gfeher

LGTM http://codereview.chromium.org/6360002/diff/1/chrome/app/policy/policy_templates.json File chrome/app/policy/policy_templates.json (left): http://codereview.chromium.org/6360002/diff/1/chrome/app/policy/policy_templates.json#oldcode65 chrome/app/policy/policy_templates.json:65: # These values are only used for the ...

9 years, 11 months ago (2011-01-14 18:24:25 UTC) #2

Jakob Kummerow

9 years, 11 months ago (2011-01-17 16:31:51 UTC) #3

Thanks for the review. I addressed your comments and will land this tomorrow
morning.

http://codereview.chromium.org/6360002/diff/1/chrome/app/policy/policy_templa...
File chrome/app/policy/policy_templates.json (left):

http://codereview.chromium.org/6360002/diff/1/chrome/app/policy/policy_templa...
chrome/app/policy/policy_templates.json:65: #   These values are only used for
the generated documentation.
On 2011/01/14 18:24:25, gfeher wrote:
> How about?
> 
> Annotations:
>   Additional information is specified under keys 'features' and
'example_value'.
> These are only used in generated documentation.

Done.

http://codereview.chromium.org/6360002/diff/1/tools/grit/grit/format/policy_t...
File tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py
(right):

http://codereview.chromium.org/6360002/diff/1/tools/grit/grit/format/policy_t...
tools/grit/grit/format/policy_templates/writers/doc_writer_unittest.py:365: #
TODO(jkummerow): apparently this is no longer needed and can be removed?
On 2011/01/14 18:24:25, gfeher wrote:
> I think it might worth keeping this until we have support for more structured
> description texts.

I updated the comment.

Expand Messages | Collapse Messages