Remove aggressive DCHECK in remoting::protocol::MessageReader()

Remove aggressive DCHECK in remoting::protocol::MessageReader()

DCHECK(!read_pending_) actually may happen and causes unnecessary crashes.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72971

[Alpha Left Google, 2011-01-28 05:36:42]

sorry sergey the DCHECK may actually for 2 scenarios that I didn't expect so
removing it.

[Alpha Left Google, 2011-01-28 05:40:12]

The case that will trigger the problem:

OnRead() calls HandleReadResult() which does a DoRead() in ProcessDoneEvent().

Arguably we can do this in OnRead() that can avoid the problem:

// inside the while loop:
if (!read_pending_)
  DoRead();

I prefer having less state checks so removed the DCHECK.

[Sergey Ulanov, 2011-01-28 07:58:29]

LGTM

On Thu, Jan 27, 2011 at 9:36 PM, <hclam@chromium.org> wrote:

> Reviewers: sergeyu,
>
> Message:
> sorry sergey the DCHECK may actually for 2 scenarios that I didn't expect
> so
> removing it.
>
>
> Description:
> Remove aggressive DCHECK in remoting::protocol::MessageReader()
>
> DCHECK(!read_pending_) actually may happen and causes unnecessary crashes.
>
> BUG=None
> TEST=None
>
> Please review this at http://codereview.chromium.org/6359018/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M remoting/protocol/message_reader.cc
>
>
> Index: remoting/protocol/message_reader.cc
> diff --git a/remoting/protocol/message_reader.cc
> b/remoting/protocol/message_reader.cc
> index
>
3bbfd59e3c6aa6dccac72dcf11b04c069a5cd07a..d8324bef224961cd13587019184b339481dba087
> 100644
> --- a/remoting/protocol/message_reader.cc
> +++ b/remoting/protocol/message_reader.cc
> @@ -40,8 +40,6 @@ void MessageReader::Init(net::Socket* socket,
>  }
>
>  void MessageReader::DoRead() {
> -  DCHECK(!read_pending_);
> -
>   // Don't try to read again if there is another read pending or we
>   // have messages that we haven't finished processing yet.
>   while (!closed_ && !read_pending_ && pending_messages_ == 0) {
>
>
>