Issue 6359011: DOMUI Prefs: Miscellaneous style tweaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6359011: DOMUI Prefs: Miscellaneous style tweaks (Closed)

Created:
9 years, 11 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI Prefs: Miscellaneous style tweaks Addresses various small review comments and other issues: - Removes the min-height for the main-page startup page list, where it doesn't make sense - Changed the min-height for other lists to a multiple of the list item heights - Removes some of the left padding in select elements - Makes the bottom shadow of subpages slightly lighter - Makes the close buttons centered vertically - Changes the input type of the Add Startup Page overlay to prevent over-aggresive validation BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72239

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -4 lines)			Patch
M	chrome/browser/resources/options/add_startup_page_overlay.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/browser_options_page.css	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/options_page.css	View	4 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks.

Expand Messages | Collapse Messages