remoting/client/plugin/pepper_view.h - Issue 6359010: Add PepperViewProxy to protect PepperView and ChromotingInstance on shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/plugin/pepper_view.h

Issue 6359010: Add PepperViewProxy to protect PepperView and ChromotingInstance on shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove unrelated files Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/client/plugin/chromoting_instance.cc ('K') | « remoting/client/plugin/chromoting_instance.cc ('k') | remoting/client/plugin/pepper_view.cc » ('j') | remoting/client/plugin/pepper_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/client/plugin/pepper_view.h

diff --git a/remoting/client/plugin/pepper_view.h b/remoting/client/plugin/pepper_view.h

index 1213533cb682917069a1736438bf10eb047c3fea..0b49a565d7d1bbad67dc89f9d459131898c4be02 100644

--- a/remoting/client/plugin/pepper_view.h

+++ b/remoting/client/plugin/pepper_view.h

@@ -3,13 +3,9 @@

// found in the LICENSE file.

// This class is an implementation of the ChromotingView using Pepper devices

-// as the backing stores. The public APIs to this class are thread-safe.

-// Calls will dispatch any interaction with the pepper API onto the pepper

-// main thread.

-//

-// TODO(ajwong): We need to better understand the threading semantics of this

-// class. Currently, we're just going to always run everything on the pepper

-// main thread. Is this smart?

+// as the backing stores. This class is used only on pepper thread.

+// Chromoting objects access this object through PepperViewProxy which

+// delegates method calls on the pepper thread.

#ifndef REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_

#define REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_