Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Unified Diff: remoting/client/plugin/pepper_view.h

Issue 6359010: Add PepperViewProxy to protect PepperView and ChromotingInstance on shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: done Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/pepper_view.h
diff --git a/remoting/client/plugin/pepper_view.h b/remoting/client/plugin/pepper_view.h
index 1213533cb682917069a1736438bf10eb047c3fea..f02a26b5465f5e16297e14f0f4479b0274d0420d 100644
--- a/remoting/client/plugin/pepper_view.h
+++ b/remoting/client/plugin/pepper_view.h
@@ -1,15 +1,11 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// This class is an implementation of the ChromotingView using Pepper devices
-// as the backing stores. The public APIs to this class are thread-safe.
-// Calls will dispatch any interaction with the pepper API onto the pepper
-// main thread.
-//
-// TODO(ajwong): We need to better understand the threading semantics of this
-// class. Currently, we're just going to always run everything on the pepper
-// main thread. Is this smart?
+// as the backing stores. This class is used only on pepper thread.
+// Chromoting objects access this object through PepperViewProxy which
+// delegates method calls on the pepper thread.
#ifndef REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_
#define REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_
@@ -79,11 +75,11 @@ class PepperView : public ChromotingView,
bool is_static_fill_;
uint32 static_fill_color_;
+ ScopedRunnableMethodFactory<PepperView> task_factory_;
+
DISALLOW_COPY_AND_ASSIGN(PepperView);
};
} // namespace remoting
-DISABLE_RUNNABLE_METHOD_REFCOUNT(remoting::PepperView);
-
#endif // REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_

Powered by Google App Engine
This is Rietveld 408576698