Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: remoting/client/plugin/pepper_view.h

Issue 6359010: Add PepperViewProxy to protect PepperView and ChromotingInstance on shutdown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove unrelated files Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This class is an implementation of the ChromotingView using Pepper devices 5 // This class is an implementation of the ChromotingView using Pepper devices
6 // as the backing stores. The public APIs to this class are thread-safe. 6 // as the backing stores. This class is used only on pepper thread.
7 // Calls will dispatch any interaction with the pepper API onto the pepper 7 // Chromoting objects access this object through PepperViewProxy which
8 // main thread. 8 // delegates method calls on the pepper thread.
9 //
10 // TODO(ajwong): We need to better understand the threading semantics of this
11 // class. Currently, we're just going to always run everything on the pepper
12 // main thread. Is this smart?
13 9
14 #ifndef REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_ 10 #ifndef REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_
15 #define REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_ 11 #define REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_
16 12
17 #include "base/scoped_ptr.h" 13 #include "base/scoped_ptr.h"
18 #include "base/task.h" 14 #include "base/task.h"
19 #include "media/base/video_frame.h" 15 #include "media/base/video_frame.h"
20 #include "ppapi/cpp/graphics_2d.h" 16 #include "ppapi/cpp/graphics_2d.h"
21 #include "remoting/client/chromoting_view.h" 17 #include "remoting/client/chromoting_view.h"
22 #include "remoting/client/frame_consumer.h" 18 #include "remoting/client/frame_consumer.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 int viewport_height_; 73 int viewport_height_;
78 74
79 bool is_static_fill_; 75 bool is_static_fill_;
80 uint32 static_fill_color_; 76 uint32 static_fill_color_;
81 77
82 DISALLOW_COPY_AND_ASSIGN(PepperView); 78 DISALLOW_COPY_AND_ASSIGN(PepperView);
83 }; 79 };
84 80
85 } // namespace remoting 81 } // namespace remoting
86 82
87 DISABLE_RUNNABLE_METHOD_REFCOUNT(remoting::PepperView); 83 DISABLE_RUNNABLE_METHOD_REFCOUNT(remoting::PepperView);
Sergey Ulanov 2011/01/25 21:29:37 Remove this.
Alpha Left Google 2011/01/25 22:20:47 Done.
88 84
89 #endif // REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_ 85 #endif // REMOTING_CLIENT_PLUGIN_PEPPER_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698