Add PepperViewProxy to protect PepperView and ChromotingInstance on shutdown

remoting/client/plugin/pepper_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/pepper_view.h"
 
 #include "base/message_loop.h"
 #include "ppapi/cpp/graphics_2d.h"
 #include "ppapi/cpp/image_data.h"
 #include "ppapi/cpp/point.h"
@@ skipping 17 matching lines @@
 }
 
 PepperView::~PepperView() {
 }
 
 bool PepperView::Initialize() {
   return true;
 }
 
 void PepperView::TearDown() {
+  DCHECK(instance_->CurrentlyOnPluginThread());
 }
 
 void PepperView::Paint() {
-  if (!instance_->CurrentlyOnPluginThread()) {
-    RunTaskOnPluginThread(NewTracedMethod(this, &PepperView::Paint));
-    return;
-  }
+  DCHECK(instance_->CurrentlyOnPluginThread());
 
   TraceContext::tracer()->PrintString("Start Paint.");
   // TODO(ajwong): We're assuming the native format is BGRA_PREMUL below. This
   // is wrong.
   if (is_static_fill_) {
     LOG(ERROR) << "Static filling " << static_fill_color_;
     pp::ImageData image(instance_, pp::ImageData::GetNativeImageDataFormat(),
                         pp::Size(viewport_width_, viewport_height_),
                         false);
     if (image.is_null()) {
       LOG(ERROR) << "Unable to allocate image of size: "
                  << viewport_width_ << "x" << viewport_height_;
       return;
     }
 
     for (int y = 0; y < image.size().height(); y++) {
       for (int x = 0; x < image.size().width(); x++) {
         *image.GetAddr32(pp::Point(x, y)) = static_fill_color_;
       }
     }
 
     // For ReplaceContents, make sure the image size matches the device context
     // size!  Otherwise, this will just silently do nothing.
     graphics2d_.ReplaceContents(&image);
     graphics2d_.Flush(TaskToCompletionCallback(
         NewTracedMethod(this, &PepperView::OnPaintDone)));

[Sergey Ulanov, 2011/01/25 21:29:37]

Do we have any guarantees that this task is not called after this object is
destroyed?
Use ScopedRunnableMethodFactory to create tasks here.

[Alpha Left Google, 2011/01/25 22:20:47]

Done.

   } else {
     // TODO(ajwong): We need to keep a backing store image of the viewport that
     // has the data here which can be redrawn.
     return;
   }
   TraceContext::tracer()->PrintString("End Paint.");
 }
 
 void PepperView::PaintFrame(media::VideoFrame* frame, UpdatedRects* rects) {
   DCHECK(instance_->CurrentlyOnPluginThread());
@@ skipping 21 matching lines @@
       // Force alpha to be set to 255.
       *image.GetAddr32(pp::Point(x, y)) =
           frame_data[y*frame_width + x] | 0xFF000000;
     }
   }
 
   // For ReplaceContents, make sure the image size matches the device context
   // size!  Otherwise, this will just silently do nothing.
   graphics2d_.ReplaceContents(&image);
   graphics2d_.Flush(TaskToCompletionCallback(
       NewTracedMethod(this, &PepperView::OnPaintDone)));

[Sergey Ulanov, 2011/01/25 21:29:37]

same here

[Alpha Left Google, 2011/01/25 22:20:47]

Done.

 
   TraceContext::tracer()->PrintString("End Paint Frame.");
 }
 
 void PepperView::SetSolidFill(uint32 color) {
-  if (!instance_->CurrentlyOnPluginThread()) {
-    RunTaskOnPluginThread(
-        NewTracedMethod(this, &PepperView::SetSolidFill, color));
-    return;
-  }
+  DCHECK(instance_->CurrentlyOnPluginThread());
 
   is_static_fill_ = true;
   static_fill_color_ = color;
 }
 
 void PepperView::UnsetSolidFill() {
-  if (!instance_->CurrentlyOnPluginThread()) {
-    RunTaskOnPluginThread(
-        NewTracedMethod(this, &PepperView::UnsetSolidFill));
-    return;
-  }
+  DCHECK(instance_->CurrentlyOnPluginThread());
 
   is_static_fill_ = false;
 }
 
 void PepperView::SetConnectionState(ConnectionState state) {
-  if (!instance_->CurrentlyOnPluginThread()) {
-    RunTaskOnPluginThread(
-        NewRunnableMethod(this, &PepperView::SetConnectionState, state));
-    return;
-  }
+  DCHECK(instance_->CurrentlyOnPluginThread());
 
   ChromotingScriptableObject* scriptable_obj = instance_->GetScriptableObject();
   switch (state) {
     case CREATED:
       SetSolidFill(kCreatedColor);
       scriptable_obj->SetConnectionInfo(STATUS_CONNECTING, QUALITY_UNKNOWN);
       break;
 
     case CONNECTED:
       UnsetSolidFill();
       scriptable_obj->SetConnectionInfo(STATUS_CONNECTED, QUALITY_UNKNOWN);
       break;
 
     case DISCONNECTED:
       SetSolidFill(kDisconnectedColor);
       scriptable_obj->SetConnectionInfo(STATUS_CLOSED, QUALITY_UNKNOWN);
       break;
 
     case FAILED:
       SetSolidFill(kFailedColor);
       scriptable_obj->SetConnectionInfo(STATUS_FAILED, QUALITY_UNKNOWN);
       break;
   }
 }
 
 void PepperView::SetViewport(int x, int y, int width, int height) {
-  if (!instance_->CurrentlyOnPluginThread()) {
-    RunTaskOnPluginThread(NewTracedMethod(this, &PepperView::SetViewport,
-                                          x, y, width, height));
-    return;
-  }
+  DCHECK(instance_->CurrentlyOnPluginThread());
 
   // TODO(ajwong): Should we ignore x & y updates?  What do those even mean?
 
   // TODO(ajwong): What does viewport x, y mean to a plugin anyways?
   viewport_x_ = x;
   viewport_y_ = y;
   viewport_width_ = width;
   viewport_height_ = height;
 
   graphics2d_ = pp::Graphics2D(instance_,
                                pp::Size(viewport_width_, viewport_height_),
                                false);
   if (!instance_->BindGraphics(graphics2d_)) {
     LOG(ERROR) << "Couldn't bind the device context.";
     return;
   }
 }
 
 void PepperView::AllocateFrame(media::VideoFrame::Format format,
                                size_t width,
                                size_t height,
                                base::TimeDelta timestamp,
                                base::TimeDelta duration,
                                scoped_refptr<media::VideoFrame>* frame_out,
                                Task* done) {
+  DCHECK(instance_->CurrentlyOnPluginThread());
+
   // TODO(ajwong): Implement this to be backed by an pp::ImageData rather than
   // generic memory.
   media::VideoFrame::CreateFrame(media::VideoFrame::RGB32,
                                  width, height,
                                  base::TimeDelta(), base::TimeDelta(),
                                  frame_out);
   if (*frame_out) {
     (*frame_out)->AddRef();
   }
   done->Run();
   delete done;
 }
 
 void PepperView::ReleaseFrame(media::VideoFrame* frame) {
+  DCHECK(instance_->CurrentlyOnPluginThread());
+
   if (frame) {
     LOG(WARNING) << "Frame released.";
     frame->Release();
   }
 }
 
 void PepperView::OnPartialFrameOutput(media::VideoFrame* frame,
                                       UpdatedRects* rects,
                                       Task* done) {
-  if (!instance_->CurrentlyOnPluginThread()) {
-    RunTaskOnPluginThread(
-        NewTracedMethod(this, &PepperView::OnPartialFrameOutput,
-                        make_scoped_refptr(frame), rects, done));
-    return;
-  }
+  DCHECK(instance_->CurrentlyOnPluginThread());
 
   TraceContext::tracer()->PrintString("Calling PaintFrame");
   // TODO(ajwong): Clean up this API to be async so we don't need to use a
   // member variable as a hack.
   PaintFrame(frame, rects);
   done->Run();
   delete done;
 }
 
 void PepperView::OnPaintDone() {
+  DCHECK(instance_->CurrentlyOnPluginThread());
+
   // TODO(ajwong):Probably should set some variable to allow repaints to
   // actually paint.
   TraceContext::tracer()->PrintString("Paint flushed");
   return;
 }
 
 }  // namespace remoting